onflow · zjumathcode · Dec 1, 2025
@@ -671,7 +671,6 @@ func generateEvents(t *testing.T, collection *flow.Collection, includeServiceEve
 	// service events are also included as regular events
 	if includeServiceEvent {
 		for _, e := range serviceEventsList {
-			e := e
 			event, err := convert.ServiceEvent(testChain, e)
 			require.NoError(t, err)
 

@@ -264,7 +264,6 @@ func (c *ComponentManager) Start(parent irrecoverable.SignalerContext) {
 
 	// launch workers
 	for _, worker := range c.workers {
-		worker := worker
 		go func() {
 			defer workersDone.Done()
 			var readyOnce sync.Once

@@ -531,8 +531,6 @@ func (c *ComponentManagerMachine) ExecuteStateTransition(t *rapid.T) {
 	}
 
 	for i, workerId := range st.workerIDs {
-		i := i
-		workerId := workerId
 		addTransition(func() {
 			wst := st.workerTransitions[i]
 			t.Logf("executing worker %v transition: %v\n", workerId, wst)

@@ -105,8 +105,6 @@ func (d *downloader) Get(ctx context.Context, executionDataID flow.Identifier) (
 	var mu sync.Mutex
 
 	for i, chunkDataID := range edRoot.ChunkExecutionDataIDs {
-		i := i
-		chunkDataID := chunkDataID
 
 		g.Go(func() error {
 			ced, cids, err := d.getChunkExecutionData(

@@ -160,8 +160,6 @@ func (p *ExecutionDataProvider) provide(ctx context.Context, blockHeight uint64,
 
 	chunkDataIDs := make([]cid.Cid, len(executionData.ChunkExecutionDatas))
 	for i, chunkExecutionData := range executionData.ChunkExecutionDatas {
-		i := i
-		chunkExecutionData := chunkExecutionData
 
 		g.Go(func() error {
 			logger.Debug().Int("chunk_index", i).Msg("adding chunk execution data")

@@ -73,7 +73,6 @@ func TestHeroQueue_Concurrent(t *testing.T) {
 	entities := unittest.EntityListFixture(uint(sizeLimit))
 	// pushing entities concurrently.
 	for _, e := range entities {
-		e := e // suppress loop variable
 		go func() {
 			require.True(t, q.Push(e.Identifier, e))
 			pushWG.Done()

@@ -56,7 +56,6 @@ func TestHeroStore_Concurrent(t *testing.T) {
 	messages := unittest.EngineMessageFixtures(sizeLimit)
 	// putting messages concurrently.
 	for _, m := range messages {
-		m := m
 		go func() {
 			require.True(t, store.Put(m))
 			putWG.Done()

@@ -29,7 +29,6 @@ func MockBlobService(bs blockstore.Blockstore) *mocknetwork.BlobService {
 			wg.Add(len(cids))
 
 			for _, c := range cids {
-				c := c
 				go func() {
 					defer wg.Done()
 

@@ -43,7 +43,6 @@ func BenchmarkStartBlockSpan(b *testing.B) {
 		{name: "cacheHit", n: 100},
 		{name: "cacheMiss", n: 100000},
 	} {
-		t := t
 		b.Run(t.name, func(b *testing.B) {
 			randomIDs := make([]flow.Identifier, 0, t.n)
 			for i := 0; i < t.n; i++ {

@@ -138,8 +138,6 @@ func TestMergeChannels(t *testing.T) {
 		channels := []chan int{make(chan int), make(chan int), make(chan int)}
 		merged := util.MergeChannels(channels).(<-chan int)
 		for i, ch := range channels {
-			i := i
-			ch := ch
 			go func() {
 				ch <- i
 				close(ch)

@@ -539,7 +539,6 @@ func TestSpamRecordCache_ConcurrentInitAndRemove(t *testing.T) {
 
 	// initialize spam records concurrently
 	for _, originID := range originIDsToAdd {
-		originID := originID // capture range variable
 		go func() {
 			defer wg.Done()
 			penalty, err := cache.AdjustWithInit(originID, adjustFnNoOp)
@@ -612,7 +611,6 @@ func TestSpamRecordCache_ConcurrentInitRemoveAdjust(t *testing.T) {
 
 	// Initialize spam records concurrently
 	for _, originID := range originIDsToAdd {
-		originID := originID // capture range variable
 		go func() {
 			defer wg.Done()
 			penalty, err := cache.AdjustWithInit(originID, adjustFnNoOp)
@@ -684,7 +682,6 @@ func TestSpamRecordCache_ConcurrentInitRemoveAndAdjust(t *testing.T) {
 
 	// initialize spam records concurrently
 	for _, originID := range originIDsToAdd {
-		originID := originID
 		go func() {
 			defer wg.Done()
 			penalty, err := cache.AdjustWithInit(originID, adjustFnNoOp)
@@ -695,7 +692,6 @@ func TestSpamRecordCache_ConcurrentInitRemoveAndAdjust(t *testing.T) {
 
 	// remove spam records concurrently
 	for _, originID := range originIDsToRemove {
-		originID := originID
 		go func() {
 			defer wg.Done()
 			cache.Remove(originID)
@@ -704,7 +700,6 @@ func TestSpamRecordCache_ConcurrentInitRemoveAndAdjust(t *testing.T) {
 
 	// adjust spam records concurrently
 	for _, originID := range originIDsToAdjust {
-		originID := originID
 		go func() {
 			defer wg.Done()
 			_, err := cache.AdjustWithInit(originID, func(record *model.ProtocolSpamRecord) (*model.ProtocolSpamRecord, error) {
@@ -773,7 +768,6 @@ func TestSpamRecordCache_ConcurrentIdentitiesAndOperations(t *testing.T) {
 
 	// initialize spam records concurrently
 	for _, originID := range originIDsToAdd {
-		originID := originID
 		go func() {
 			defer wg.Done()
 			penalty, err := cache.AdjustWithInit(originID, adjustFnNoOp)
@@ -787,7 +781,6 @@ func TestSpamRecordCache_ConcurrentIdentitiesAndOperations(t *testing.T) {
 
 	// remove spam records concurrently
 	for _, originID := range originIDsToRemove {
-		originID := originID
 		go func() {
 			defer wg.Done()
 			require.True(t, cache.Remove(originID))

@@ -258,7 +258,6 @@ func TestSubscriptionCache_ConcurrentUpdate(t *testing.T) {
 	// verify that all peers have all topics; concurrently
 	allTopicsVerified := sync.WaitGroup{}
 	for _, pid := range peerIds {
-		pid := pid
 		allTopicsVerified.Add(1)
 		go func() {
 			defer allTopicsVerified.Done()

@@ -752,7 +752,6 @@ func EnsureNoPubsubMessageExchange(t *testing.T,
 
 	wg := &sync.WaitGroup{}
 	for _, node := range from {
-		node := node // capture range variable
 		for i := 0; i < count; i++ {
 			wg.Add(1)
 			go func() {

@@ -54,7 +54,6 @@ func TestRPCSentTracker_IHave(t *testing.T) {
 		}
 		iHaves := make([]*pb.ControlIHave, len(testCases))
 		for i, testCase := range testCases {
-			testCase := testCase
 			iHaves[i] = &pb.ControlIHave{
 				MessageIDs: testCase.messageIDS,
 			}