Skip to content

[Access] Export scheduled tx extended indexer types#8506

Open
peterargue wants to merge 1 commit intomasterfrom
peter/extended-indexer-improvements
Open

[Access] Export scheduled tx extended indexer types#8506
peterargue wants to merge 1 commit intomasterfrom
peter/extended-indexer-improvements

Conversation

@peterargue
Copy link
Contributor

@peterargue peterargue commented Mar 25, 2026

Summary by CodeRabbit

  • Refactor
    • Internal code structure improvements for enhanced maintainability and consistency.

@peterargue peterargue requested a review from a team as a code owner March 25, 2026 20:23
@github-actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 627cf45.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 87d1a2e9-aad5-4ec1-b2b0-15284b78115e

📥 Commits

Reviewing files that changed from the base of the PR and between a355078 and 627cf45.

📒 Files selected for processing (3)
  • module/state_synchronization/indexer/extended/scheduled_transaction_requester.go
  • module/state_synchronization/indexer/extended/scheduled_transaction_requester_test.go
  • module/state_synchronization/indexer/extended/scheduled_transactions.go

📝 Walkthrough

Walkthrough

Three Go files were updated to promote internal scheduled transaction metadata struct types to exported status with capitalized field names, allowing external packages to access these previously private types. All field references throughout the module were updated consistently to reflect the new naming convention.

Changes

Cohort / File(s) Summary
Struct Type Definitions
module/state_synchronization/indexer/extended/scheduled_transactions.go
Promoted unexported types executedEntry, canceledEntry, failedEntry to exported ExecutedEntry, CanceledEntry, FailedEntry. Updated ScheduledTransactionsMetadata struct fields to reference the new exported types with capitalized field names (eventEvent, transactionIDTransactionID, scheduledTxIDScheduledTxID).
Field Access Updates
module/state_synchronization/indexer/extended/scheduled_transaction_requester.go
Updated field accesses in Fetch method to match renamed struct fields: entry.evententry.Event, entry.transactionIDentry.TransactionID, entry.scheduledTxIDentry.ScheduledTxID.
Test Data Construction
module/state_synchronization/indexer/extended/scheduled_transaction_requester_test.go
Updated test fixtures to construct instances using exported struct types and capitalized field names for ExecutedEntry, CanceledEntry, and FailedEntry in test cases.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Hops with delight at structs now exposed,
Private fields donned their capitalized clothes,
From entry.event to entry.Event so bright,
The module shines with visibility's light!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: exporting internal struct types (ExecutedEntry, CanceledEntry, FailedEntry) from the scheduled transaction extended indexer module.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch peter/extended-indexer-improvements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ization/indexer/extended/scheduled_transactions.go 53.33% 5 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Why do we need them exported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants