Update to Cadence v1.7.0 #91
Conversation
WalkthroughUpdated dependency versions in go.mod across multiple ecosystems (Flow/Cadence, Ethereum, OpenTelemetry, Google Cloud/GRPC/Protobuf, AWS SDK v2, and testing). No source code changes or public API alterations are included in this diff. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
go.mod (1)
3-3: Invalid go directive: use "go 1.25" (no patch) and ensure toolchain is available in CI."go 1.25.0" is not a valid value; the go directive only accepts major.minor.
Apply this diff:
-go 1.25.0 +go 1.25Follow-up: after changing, run
go mod tidy -compat=1.25.
🧹 Nitpick comments (2)
go.mod (2)
26-27: OTel version skew; consider aligning all otel packages to 1.37.x.*SDK is 1.37.0 but exporters are older (e.g., otlpmetricgrpc 1.34.0, otlptrace 1.31.0). Keeping OTel packages on the same minor reduces churn and avoids subtle API drifts.
Happy to raise a follow-up PR to bump:
- go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc -> v1.37.0
- go.opentelemetry.io/otel/exporters/otlp/otlptrace -> v1.37.0
- go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc -> v1.37.0
113-127: AWS SDK v2 family partly bumped — align services to the same minor train.Core/sdk are 1.38.x but s3 (v1.15.0) and s3shared (v1.7.0) remain older; minor misalignments can break presign/signer behavior.
Propose updating:
- github.com/aws/aws-sdk-go-v2/service/s3 -> latest 1.38.x-compatible
- github.com/aws/aws-sdk-go-v2/service/internal/s3shared -> matching minor
- github.com/aws/aws-sdk-go-v2/feature/s3/manager -> matching minor
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod(6 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
🔇 Additional comments (5)
go.mod (5)
20-20: Testify bump LGTM.v1.11.1 is a safe minor; expect no breaking assertions for typical usage.
38-38: Verify ADC and metadata probing paths post-auth bump
No direct references to ADC or metadata packages were found in Go code; please manually confirm that default credential resolution and metadata server probing behavior in your production environment remains correct after bumping cloud auth dependencies.
11-11: Unify go-ethereum module imports in go.mod
go.mod currently lists both github.com/ethereum/go-ethereum@v1.16.3 (line 11) and github.com/onflow/go-ethereum@v1.16.2 (indirect, line 271). Verify that no code is directly importing types from the onflow fork. If you intend to use only the upstream client, add a replace directive in go.mod such as:replace github.com/onflow/go-ethereum => github.com/ethereum/go-ethereum v1.16.3then run
go mod tidyto prune the unused module.
99-99: Scan for removed/renamed Google APIs after wide genproto snapshot bump
The top-levelgoogle.golang.org/genprotomodule remains at v0.0.0-20250603155806, while nested modules advanced to v0.0.0-20250707201910 and v0.0.0-20250804133106; ensure no fields or options removed/renamed by these snapshots are referenced in your code.
15-17: Flow/Cadence dependencies updated — run full integration and fixture checks
- go.mod (lines 15–17): cadence v1.7.0, flow-go v0.43.0-dev-pebble.1.0.20250910132853-12699a150fd9, flow-go-sdk v1.8.1 confirmed
- No imports of cadence.runtime/ast/sema or flow-go-sdk client/crypto/sign detected
- Tests present in state/convert_test.go and script/script_test.go
Please run the full integration suite and fixture checks to validate Rosetta endpoints, script decoding, and protobuf/JSON round-trips.
| google.golang.org/grpc v1.75.0 | ||
| google.golang.org/protobuf v1.36.7 |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
gRPC/protobuf/genproto upgraded — confirm generated stubs are up to date.
Upgrading grpc/protobuf/genproto without regenerating can cause wire/runtime mismatches.
If regeneration is needed, document protoc/protoc-gen-go/protoc-gen-go-grpc versions in CONTRIBUTING.
Also applies to: 344-345
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Check generated files' protoc plugin headers for version drift
rg -nP -g '!**/vendor/**' -S '^//\s*Code generated by protoc-gen-go(-grpc)?' -C0
# List effective versions
go list -m -json google.golang.org/grpc google.golang.org/protobuf google.golang.org/genproto \
| jq -r '.Path+" "+.Version'Length of output: 148
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Show go.mod entries for grpc/protobuf/genproto
grep -E 'google.golang.org/(grpc|protobuf|genproto)' go.mod -n || true
# Inspect generated .pb.go files for protoc-gen-go headers
rg -nP --type go '^// Code generated by protoc-gen-go(-grpc)?' -g '*.pb.go' -C0 || true
# List effective module versions
go list -m -json google.golang.org/grpc google.golang.org/protobuf google.golang.org/genproto \
| jq -r '.Path+" "+.Version'Length of output: 707
Regenerate protobuf & gRPC stubs to match updated modules
- Regenerate all
.pb.goand_grpc.pb.gofiles using protoc with protoc-gen-go v1.36.7 and protoc-gen-go-grpc v1.2.0 to align with go.mod (grpc v1.75.0, protobuf v1.36.7, genproto updates) - Document exact protoc, protoc-gen-go and protoc-gen-go-grpc versions in CONTRIBUTING
Description
Automatically update to:
Summary by CodeRabbit