Skip to content

Conversation

@masnwilliams
Copy link
Contributor

@masnwilliams masnwilliams commented Aug 20, 2025

TL;DR

Refactored and extracted authentication exemption logic in the root command to allow help and completion commands to run without requiring authentication.

Why we made these changes

To improve the robustness and clarity of authentication bypass logic for non-sensitive commands like help and shell completion, enhancing user experience by allowing these fundamental functions to operate without login.

What changed?

  • cmd/root.go:
    • Introduced a new isAuthExempt helper function.
    • Updated the PersistentPreRunE hook to leverage isAuthExempt for determining authentication bypass for commands like help and completion.

Description generated by Mesa. Update settings

@masnwilliams masnwilliams requested a review from rgarcia August 20, 2025 00:45
Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of d579cf8...d34c5d9

1 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings

@masnwilliams masnwilliams merged commit 404b4a0 into main Aug 20, 2025
2 checks passed
@masnwilliams masnwilliams deleted the mason/allow-unauthed-help-completion branch August 25, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants