Skip to content

Conversation

@mateoCuervo
Copy link
Contributor

@mateoCuervo mateoCuervo commented Nov 13, 2025

adding support in cli for viewport 1200x800

Tested

Works with flag --viewport
image

Works with flag --viewport-interactive
image

works on dashboard /browsers
image

@mesa-dot-dev
Copy link

mesa-dot-dev bot commented Nov 13, 2025

Mesa Description

This PR adds a new 1200x800 viewport option for browser testing, a common desktop resolution.

  • Added "1200x800@60" to the list of available viewports.
  • Updated the --viewport flag's help text to include the new option.
  • Updated the unit test in cmd/browsers_test.go to validate the addition, increasing the expected count of viewports from 5 to 6.

Description generated by Mesa. Update settings

Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of 5abf789...4f522e0

Analysis

  1. The new viewport option disrupts the existing ordering scheme (by width descending), as 1200x800 is placed after 1024x768, which could impact code maintainability and user experience if these options are displayed in this order.
  2. While not a major architectural issue, inconsistent ordering patterns may make future maintenance more difficult and could introduce confusion for developers working with the viewport options array.

Tip

Help

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

2 files reviewed | 0 comments | Edit Agent SettingsRead Docs

@mateoCuervo mateoCuervo requested a review from rgarcia November 13, 2025 15:40
@mateoCuervo mateoCuervo merged commit c27e844 into main Nov 13, 2025
2 checks passed
@mateoCuervo mateoCuervo deleted the feat/add-viewport-1200-8000 branch November 13, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants