Skip to content

Package dependency update pass#212

Merged
anoek merged 1 commit intomainfrom
upgrade-packages
Nov 4, 2025
Merged

Package dependency update pass#212
anoek merged 1 commit intomainfrom
upgrade-packages

Conversation

@anoek
Copy link
Member

@anoek anoek commented Nov 4, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Review Findings

After analyzing this dependency update PR, I found one potential issue:

Version Mismatch: React Types vs Runtime

In package.json:

  • @types/react: 19.2.2
  • @types/react-dom: 19.2.2
  • react: 19.2.0 (locked)
  • react-dom: 19.2.0 (locked via overrides)

The TypeScript type definitions are for version 19.2.2, but the actual React packages are locked to 19.2.0. While this may work in practice, there's a risk that the type definitions could reference APIs or behaviors added in patch versions 19.2.1 or 19.2.2 that don't exist in 19.2.0.

Recommendation: Either update the React packages to match the types version (19.2.2), or downgrade the types to match the React version (19.2.0) for consistency.


All other changes look good:

  • ✅ ESLint config properly migrated to @Stylistic plugin
  • ✅ React component types updated to React.JSX.Element (correct for React 19)
  • ✅ Jest matchers updated to non-deprecated APIs
  • skipLibCheck addition is reasonable for managing type complexities

@anoek anoek merged commit 76a7725 into main Nov 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants