Put stone_removal_expiration onto AdHocClock #216
Conversation
…e time remaining.
Code ReviewI've analyzed this PR and the changes look good overall. The fix correctly addresses the issue where the stone removal clock wasn't resetting properly by using the more specific Minor observation:The The logic using |
|
My Claude added the other field because technically this is what the server uses to indicate that the stone_removal_expiration is valid. Goban infers this indirectly instead as it happens. But the server is sending it, so it is in the JSON that's being described. |
|
Awesome, thanks for digging into that and getting it fixed! |
…and use it to correctly calculate the stone removal time remaining.
(Fixes bug where clicking on the board during stone removal did not appear to reset the clock, so the clock appeared to count down to zero before it actually was at zero)