Skip to content

Fix joseki zone counting bug #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anoek merged 1 commit into from
Jan 3, 2026
Merged

Fix joseki zone counting bug #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/engine/ai/categorize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,10 @@ function detectJosekiMoves(engine: GobanEngine, score_loss_list: ScoreLossList):
continue;
}

// Always count the move in this zone before any exit checks
zoneState.moves_in_zone[zone] += 1;
zoneState.zone_loss[zone] += move_loss;

// Check if move is on the edge near an adjacent zone that's not in joseki
if (num_zones === 8) {
const nearbyAdjacent = getNearbyAdjacentZones(x, y, width, height, zone);
Expand All @@ -424,9 +428,6 @@ function detectJosekiMoves(engine: GobanEngine, score_loss_list: ScoreLossList):
}
}

zoneState.moves_in_zone[zone] += 1;
zoneState.zone_loss[zone] += move_loss;

// First move in a zone gets 2x threshold tolerance
const effectiveSingleMoveThreshold =
zoneState.moves_in_zone[zone] === 1
Expand Down
Loading