Type hints for the module conf#1719
Merged
MaxHalford merged 5 commits intoonline-ml:mainfrom Nov 11, 2025
Merged
Conversation
e10e3
requested review from
AdilZouitine,
MaxHalford and
smastelini
as code owners
MaxHalford
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like with #1698, this module is relatively standalone, making type-checking changes easy.
RegressionJackknifeis now generic over the model it wraps because it inherits frombase.Wrapperwhich is already generic.RegressionJackknife.predict_onehas overloads because it returns a different type of data depending on the value of thewith_intervalparameter.I added a few return type hints in
stats.Quantilefor the methods called in the module.