Conversation
This reverts commit 6984c5c.
Member
|
Yes apologies for having pushed that to main. I made a separate branch where I'm attempting to use uv. It should make life easier! |
Contributor
Author
|
No worries. I know that debugging Github Actions is a pain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 6984c5c.
Commit 6984c5c changed the build system to Setuptools instead of Poetry's own
poetry-core.Unfortunately, this change prevents River from being built and breaks CI 🙁.
River, with its C++ and Rust extensions, needs an external compilation step and is currently configured for poetry-core.
Using Setuptools could certainly be done, but it requires more configuration change than swapping the build system 😄.
I propose to restore the ability to build River with Poetry for the time being, and if the transition to Setuptools is wanted, that a follow-up PR can bring a more complete transition.