Supabase CI/CD by Kitenite · Pull Request #1891 · onlook-dev/onlook

Kitenite · 2025-05-20T22:24:03Z

Description

Related Issues

Type of Change

Testing

Screenshots (if applicable)

Additional Notes

Important

Adds CI/CD workflow for Supabase migrations and enables row-level security in database schema.

CI/CD Workflow:
- Adds .github/workflows/supabase-staging.yml for deploying Drizzle migrations to Supabase staging on main branch push or manual dispatch.
- Uses bun for package management and running db:push.
Database Migrations:
- Adds 0000_same_human_robot.sql and 0001_graceful_exodus.sql for creating tables and enabling row-level security.
- Updates meta/0000_snapshot.json and meta/0001_snapshot.json for migration snapshots.
- Updates meta/_journal.json to track migration history.
Configuration and Schema:
- Updates drizzle.config.ts to change migration output path.
- Enables row-level security in conversation.ts and message.ts.

^{This description was created by}^{for cb9df7e. You can customize this summary. It will automatically update as commits are pushed.}

…ronments Co-Authored-By: kiet@onlook.dev <kiet@onlook.dev>

Co-Authored-By: kiet@onlook.dev <kiet@onlook.dev>

vercel · 2025-05-20T22:24:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	🛑 Canceled (Inspect)			May 20, 2025 10:43pm
web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 20, 2025 10:43pm

supabase · 2025-05-20T22:24:09Z

This pull request has been ignored for the connected project wowaemfasoptxrdjhilu because there are no changes detected in apps/backend/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

ellipsis-dev

Caution

Changes requested ❌

Reviewed everything up to 87d75c4 in 1 minute and 44 seconds. Click for details.

Reviewed 657 lines of code in 5 files
Skipped 0 files when reviewing.
Skipped posting 3 draft comments. View those below.
Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. .github/workflows/supabase-ci.yml:20

Draft comment:
Ensure 'supabase start' runs in non‐blocking mode or add a cleanup step to shut down the environment after tests.
Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% In GitHub Actions, processes continue running until explicitly killed or the job ends. The current command 'supabase start' likely blocks until Supabase is ready, which is actually desirable to ensure the database is available before running migrations. Adding -d could make the workflow less reliable by continuing before Supabase is ready. The cleanup concern is not critical since GitHub Actions cleans up automatically when jobs complete. Maybe blocking is bad for workflow performance? Maybe there are resource leaks that cleanup would prevent? Blocking is actually good here - it ensures Supabase is ready. GitHub Actions handles cleanup automatically when jobs finish. The comment should be deleted. The current blocking behavior is correct and cleanup is handled automatically by GitHub Actions.

2. packages/db/src/migrations/0000_salty_blink.sql:1

Draft comment:
Consider removing or documenting the '--> statement-breakpoint' comments if they aren’t needed in production migrations.
Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The statement-breakpoint comments appear to be automatically generated by a database migration tool. They likely serve a specific purpose in the migration process. Without understanding the migration tooling being used, suggesting their removal could be harmful. Additionally, this seems more like a tooling/configuration question rather than a code issue. I might be wrong about these being tool-generated - they could be manually added comments that are indeed unnecessary. Also, even if tool-generated, maybe they should be cleaned up. Given this is a migration file and the comments appear systematic throughout the file, it's very likely these are intentionally placed by the migration tooling. Removing them could break the migration process. This comment should be deleted as it suggests modifying what appears to be tool-generated syntax without clear evidence that this would be beneficial or safe.

3. .github/workflows/supabase-ci.yml:1

Draft comment:
The PR description mentions onboarding docs updates (Next.js, Remix, Webpack, Babel) but the changes focus on CI/CD and migrations. Verify that the documentation updates are included as intended.
Reason this comment was not posted:
Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify that the documentation updates are included as intended, which is against the rules. It is not making a specific code suggestion or pointing out a specific issue with the code itself.

Workflow ID: wflow_tEC5FDkl7FOE9tkj

^{You can customize}^{by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

ellipsis-dev · 2025-05-20T22:25:50Z

.github/workflows/supabase-ci.yml

+
+      - uses: supabase/setup-cli@v1
+        with:
+          version: latest


Pin the Supabase CLI version instead of using 'latest' to prevent unexpected breaking changes.

Suggested change

version: latest

version: 1.123.4

ellipsis-dev · 2025-05-20T22:25:50Z

.github/workflows/supabase-staging.yml

+
+      - uses: oven-sh/setup-bun@v1
+        with:
+          bun-version: latest


Pin the Bun version rather than using 'latest' to ensure stable builds.

Suggested change

bun-version: latest

bun-version: 1.0.25

ellipsis-dev

Important

Looks good to me! 👍

Reviewed 6de6f0b in 31 seconds. Click for details.

Reviewed 33 lines of code in 1 files
Skipped 0 files when reviewing.
Skipped posting 2 draft comments. View those below.
Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. .github/workflows/supabase-ci.yml:1

Draft comment:
Removing this CI workflow eliminates automated migration validations. Confirm if this removal is intentional.
Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. .github/workflows/supabase-ci.yml:1

Draft comment:
PR title and issue mention onboarding docs improvements, but this diff only removes CI/CD. Please clarify the intended scope.
Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_7jW8zWYekih6kWjF

^{You can customize}^{by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

ellipsis-dev

Important

Looks good to me! 👍

Reviewed 018115b in 51 seconds. Click for details.

Reviewed 48 lines of code in 3 files
Skipped 0 files when reviewing.
Skipped posting 4 draft comments. View those below.
Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. apps/backend/supabase/migrations/meta/0000_snapshot.json:2

Draft comment:
Ensure the new migration 'id' (95612ed1-7374-41c8-8f07-1ee3b064226b) is intentional and consistent with your migration history.
Reason this comment was not posted:
Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the author to ensure that the migration ID is intentional and consistent with the migration history. This is a request for confirmation, which violates the rules. The comment does not provide a specific suggestion or point out a specific issue with the code.

2. apps/backend/supabase/migrations/meta/_journal.json:8

Draft comment:
Verify the updated timestamp (1747780205535) and tag ('0000_same_human_robot') match the intended migration entry details.
Reason this comment was not posted:
Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify details, which violates the rule against asking for confirmation or verification. It doesn't provide a specific suggestion or point out a clear issue with the code.

3. packages/db/drizzle.config.ts:6

Draft comment:
Confirm the updated migration output path ('../../apps/backend/supabase/migrations') is correct; also consider adding a newline at the end of the file for best practice.
Reason this comment was not posted:
Comment did not seem useful. Confidence is useful = 50% <= threshold 50% The comment asks the author to confirm the updated migration output path, which violates the rule against asking for confirmation of intention. However, the suggestion to add a newline at the end of the file is a valid code style suggestion.

4. packages/db/drizzle.config.ts:1

Draft comment:
The PR description mentions onboarding docs improvements, but no documentation changes are present. Ensure that the onboarding documentation updates are added if intended.
Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_epIBMl2VRshNXdaH

^{You can customize}^{by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

ellipsis-dev

Important

Looks good to me! 👍

Reviewed 782eeb1 in 38 seconds. Click for details.

Reviewed 26 lines of code in 2 files
Skipped 0 files when reviewing.
Skipped posting 2 draft comments. View those below.
Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. packages/db/src/schema/project/chat/conversation.ts:17

Draft comment:
Ensure that corresponding RLS policies are configured for the 'conversations' table; without them, all access will be blocked by default.
Reason this comment was not posted:
Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the author to ensure that RLS policies are configured, which is similar to asking them to double-check or ensure behavior. This violates the rule against asking the author to ensure something is done.

2. packages/db/src/schema/project/chat/message.ts:23

Draft comment:
Ensure that corresponding RLS policies are configured for the 'messages' table to allow intended operations.
Reason this comment was not posted:
Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to ensure that RLS policies are configured, which falls under the rule of not asking the author to ensure something is done. It doesn't provide a specific suggestion or point out a specific issue with the code.

Workflow ID: wflow_uUl4fTVDIsS8tikz

^{You can customize}^{by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

ellipsis-dev

Important

Looks good to me! 👍

Reviewed 5e20fa3 in 1 minute and 1 seconds. Click for details.

Reviewed 13 lines of code in 1 files
Skipped 0 files when reviewing.
Skipped posting 1 draft comments. View those below.
Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. .github/workflows/supabase-staging.yml:21

Draft comment:
Changing the bun-version from a fixed '1.2.13' to a wildcard '1.2.x' may lead to non-deterministic builds if a new minor version introduces breaking changes. Consider pinning a specific version unless you intend to auto-update and have proper testing in place. Also, the PR description mentions onboarding docs (issue 123) but no documentation updates are present here. Please ensure the PR either includes those changes or update the description accordingly.
Reason this comment was not posted:
Comment did not seem useful. Confidence is useful = 50% <= threshold 50% The comment contains two parts. The first part discusses the change from a fixed version to a wildcard version, which is a valid concern about non-deterministic builds and suggests pinning a specific version. This is a useful comment. The second part asks the PR author to update the PR description, which violates the rules. I will approve the first part of the comment and disapprove the second part.

Workflow ID: wflow_5vZCYBEfFrJJdgnx

^{You can customize}^{by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

ellipsis-dev

Important

Looks good to me! 👍

Reviewed cb9df7e in 1 minute and 12 seconds. Click for details.

Reviewed 12 lines of code in 1 files
Skipped 0 files when reviewing.
Skipped posting 2 draft comments. View those below.
Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. .github/workflows/supabase-staging.yml:6

Draft comment:
Removed branch 'ci/supabase' from the push triggers. Confirm that this removal is intentional and that you don't need pushes to 'ci/supabase' to trigger the workflow.
Reason this comment was not posted:
Comment looked like it was already resolved.

2. .github/workflows/supabase-staging.yml:1

Draft comment:
The PR title and issue description mention onboarding docs for various frameworks, but the changes only adjust a CI/CD workflow for Supabase staging. Please align the PR title/description with the actual changes.
Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_JbLcGPzx7YA7YSNn

^{You can customize}^{by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

ellipsis-dev

Important

Looks good to me! 👍

Reviewed adbd45f in 1 minute and 58 seconds. Click for details.

Reviewed 517 lines of code in 3 files
Skipped 0 files when reviewing.
Skipped posting 4 draft comments. View those below.
Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. apps/backend/supabase/migrations/0001_graceful_exodus.sql:1

Draft comment:
The SQL statement on this line includes an inline string '--> statement-breakpoint' right after the semicolon. This may not be valid SQL formatting. Please remove or properly format the comment (e.g. by placing it on a separate line with '-- ') to avoid potential parsing issues.
Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The "--> statement-breakpoint" appears to be a special directive used by the migration system, not a regular SQL comment. This is likely intentional and part of the migration tooling. Many SQL migration tools use special markers like this to handle statement separation. The comment shows a misunderstanding of the tooling. I could be wrong about the purpose of the statement-breakpoint marker. Maybe it really is a mistake or could cause issues with some SQL parsers. The consistent use of this marker in the migration file and its specific format strongly suggests it's an intentional directive for the migration system, not a mistake. The comment should be deleted as it incorrectly identifies a migration tool directive as a SQL formatting issue.

2. apps/backend/supabase/migrations/meta/0001_snapshot.json:482

Draft comment:
The file does not end with a newline. It’s a good practice to end files with a newline for consistency.
Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While having a newline at end of file is a common convention, this is a very minor formatting issue. The file is a generated JSON schema file, likely created by a tool. Such files often don't need to follow the same style conventions as source code. The comment doesn't point out a functional issue or suggest an important improvement. The newline at end of file convention does have some historical technical reasons and is part of the POSIX standard. Some tools may behave differently without it. While technically correct, for a JSON schema file this is an extremely minor issue that doesn't impact functionality. The effort of fixing and reviewing this change outweighs any benefit. Delete this comment as it points out a trivial formatting issue in a generated file that doesn't meaningfully impact the codebase.

3. apps/backend/supabase/migrations/meta/_journal.json:1

Draft comment:
The PR description mentions adding onboarding documentation for frameworks (Next.js, Remix, Webpack, Babel), but the diff only contains Supabase migration updates. Ensure that the documentation changes are also included to fully address the issue.
Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.

4. apps/backend/supabase/migrations/0001_graceful_exodus.sql:1

Draft comment:
Typo: The text "--> statement-breakpoint" appears to be a leftover artifact after the semicolon. Please remove it if it's not intended as part of the SQL statement.
Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% "--> statement-breakpoint" is actually a common directive used in SQL migration tools to explicitly mark where statements should be split. It's not a typo - it's an intentional marker used by migration frameworks. The comment is incorrect in assuming this is an error. I could be wrong about the specific migration tool being used here. Different tools might have different syntax for statement breaks. Even if this specific syntax isn't for the tool being used, the consistent placement and format suggests it's intentional rather than a typo. We should err on the side of assuming the author knows what they're doing. Delete this comment as it incorrectly identifies an intentional migration directive as a typo.

Workflow ID: wflow_7E0BZnLpcpNMCjR4

^{You can customize}^{by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

* Add GitHub Actions workflows for Supabase staging and production environments * add migration files * update migration path --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: kiet@onlook.dev <kiet@onlook.dev>

devin-ai-integration bot and others added 6 commits May 18, 2025 22:38

Add GitHub Actions workflows for Supabase staging and production envi…

f3ea921

…ronments Co-Authored-By: kiet@onlook.dev <kiet@onlook.dev>

Update environment variable names to be more specific

aff144d

Co-Authored-By: kiet@onlook.dev <kiet@onlook.dev>

update readme

01aae91

Merge branch 'main' into devin/1747607854-add-supabase-env-workflows

20ba6ae

add migration files

507a7d1

add branch

87d75c4

vercel bot deployed to Preview – web May 20, 2025 22:24 View deployment

vercel bot deployed to Preview – docs May 20, 2025 22:24 View deployment

ellipsis-dev bot reviewed May 20, 2025

View reviewed changes

Kitenite added 2 commits May 20, 2025 15:27

update command

638373d

remove schema validation

6de6f0b

ellipsis-dev bot reviewed May 20, 2025

View reviewed changes

vercel bot deployed to Preview – docs May 20, 2025 22:28 View deployment

vercel bot deployed to Preview – web May 20, 2025 22:30 View deployment

update migration path

018115b

ellipsis-dev bot reviewed May 20, 2025

View reviewed changes

vercel bot deployed to Preview – web May 20, 2025 22:32 View deployment

vercel bot deployed to Preview – docs May 20, 2025 22:32 View deployment

update schema

782eeb1

ellipsis-dev bot reviewed May 20, 2025

View reviewed changes

vercel bot deployed to Preview – docs May 20, 2025 22:37 View deployment

pin bun version

ced4fb7

vercel bot deployed to Preview – web May 20, 2025 22:39 View deployment

Kitenite added 3 commits May 20, 2025 15:39

pin bun version

5e20fa3

add migration files

adbd45f

disable main

cb9df7e

ellipsis-dev bot reviewed May 20, 2025

View reviewed changes

vercel bot deployed to Preview – web May 20, 2025 22:42 View deployment

vercel bot deployed to Preview – docs May 20, 2025 22:43 View deployment

Kitenite merged commit 3884deb into main May 20, 2025
4 checks passed

Kitenite deleted the ci/supabase branch May 20, 2025 22:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Supabase CI/CD#1891

Supabase CI/CD#1891
Kitenite merged 14 commits intomainfrom
ci/supabase

Kitenite commented May 20, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

vercel bot commented May 20, 2025 •

edited

Loading

Uh oh!

supabase bot commented May 20, 2025

Uh oh!

ellipsis-dev bot left a comment

Uh oh!

ellipsis-dev bot May 20, 2025

Uh oh!

ellipsis-dev bot May 20, 2025

Uh oh!

ellipsis-dev bot left a comment

Uh oh!

ellipsis-dev bot left a comment

Uh oh!

ellipsis-dev bot left a comment

Uh oh!

ellipsis-dev bot left a comment

Uh oh!

ellipsis-dev bot left a comment

Uh oh!

ellipsis-dev bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Kitenite commented May 20, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Type of Change

Testing

Screenshots (if applicable)

Additional Notes

Uh oh!

vercel bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

supabase bot commented May 20, 2025

Uh oh!

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot May 20, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot May 20, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Kitenite commented May 20, 2025 •

edited by ellipsis-dev bot

Loading

vercel bot commented May 20, 2025 •

edited

Loading