Skip to content

fix: update compression to be more aggressive #2962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2025
+13 −5
Merged

fix: update compression to be more aggressive #2962

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0a4082
update compression to be more aggressive
Kitenite Oct 6, 2025
cbc3f98
use aggressive defaults
Kitenite Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions packages/utility/src/image.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,21 @@
import imageCompression from 'browser-image-compression';
import { DefaultSettings } from '@onlook/constants';
import { normalizePath } from './folder';
import imageCompression from 'browser-image-compression';
import { isImageFile } from './file';
import { normalizePath } from './folder';

// Browser-side image compression
export async function compressImageInBrowser(file: File): Promise<string | undefined> {
export async function compressImageInBrowser(
file: File,
compressionOptions?: {
maxSizeMB?: number;
maxWidthOrHeight?: number;
quality?: number;
}
): Promise<string | undefined> {
const options = {
maxSizeMB: 2,
maxWidthOrHeight: 2048,
maxSizeMB: compressionOptions?.maxSizeMB ?? 0.2,
maxWidthOrHeight: compressionOptions?.maxWidthOrHeight ?? 512,
quality: compressionOptions?.quality ?? 0.6,
Comment on lines +16 to +18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a discrepancy between the PR description and implementation. The PR description states that the default compression values should be:

  • maxSizeMB: 2
  • maxWidthOrHeight: 2048
  • quality: 0.8

However, the implementation sets more aggressive defaults:

  • maxSizeMB: 0.2
  • maxWidthOrHeight: 512
  • quality: 0.6

These more aggressive defaults will result in smaller file sizes but potentially lower image quality than what was specified in the PR description. Consider aligning the implementation with the documented defaults to ensure consistent behavior.

Suggested change
maxSizeMB: compressionOptions?.maxSizeMB ?? 0.2,
maxWidthOrHeight: compressionOptions?.maxWidthOrHeight ?? 512,
quality: compressionOptions?.quality ?? 0.6,
maxSizeMB: compressionOptions?.maxSizeMB ?? 2,
maxWidthOrHeight: compressionOptions?.maxWidthOrHeight ?? 2048,
quality: compressionOptions?.quality ?? 0.8,

Spotted by Diamond

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

};

try {
Expand Down