Skip to content

fix(packaging): include runtime files in tarball#10

Merged
onmax merged 2 commits intomainfrom
fix/pkg-runtime-files
Feb 23, 2026
Merged

fix(packaging): include runtime files in tarball#10
onmax merged 2 commits intomainfrom
fix/pkg-runtime-files

Conversation

@onmax
Copy link
Copy Markdown
Owner

@onmax onmax commented Feb 23, 2026

summary

  • clean dist before prepack so a prior stub symlink cannot leak into package artifacts
  • add pkg workflow check to fail if runtime files are missing or dist/runtime is still a symlink
  • add a short README note showing explicit #imports usage for editors outside Nuxt auto-import context

validation

  • pnpm lint
  • pnpm test
  • pnpm typecheck
  • reproduced packaging flow: pnpm dev:prepare && pnpm prepack && pnpm pack now includes dist/runtime/** in tarball
  • consumer check in /tmp app: server/utils useSafeRuntimeConfig() typechecks with the packed tarball

related

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nuxt-safe-runtime-config Ready Ready Preview, Comment Feb 23, 2026 10:27am
safe-runtime-config Ready Ready Preview, Comment Feb 23, 2026 10:27am

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Feb 23, 2026

Open in StackBlitz

npm i https://pkg.pr.new/onmax/nuxt-safe-runtime-config@10

commit: 37f9bbe

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7d1a915098

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

package.json Outdated
],
"scripts": {
"prepack": "nuxt-module-build build && unbuild",
"clean:dist": "rm -rf dist",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Replace Unix-only dist cleanup command

Using rm -rf dist in clean:dist makes prepack fail on Windows shells, where rm is not a recognized command. Since prepack runs during pnpm pack/publish flows, maintainers on Windows (or Windows CI runners) cannot produce or publish the package after this change. Please switch to a cross-platform cleanup command (for example via a Node script or a portable utility) so packaging works across supported development environments.

Useful? React with 👍 / 👎.

@onmax onmax merged commit 4059251 into main Feb 23, 2026
6 checks passed
@onmax onmax deleted the fix/pkg-runtime-files branch February 23, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typescript error: Config is of type 'unknown'

1 participant