Skip to content

Upgrading llvm and stablehlo hash #3053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 14, 2025
Merged

Upgrading llvm and stablehlo hash #3053

merged 11 commits into from
Feb 14, 2025

Conversation

@christopherlmunoz
Copy link
Contributor

@christopherlmunoz christopherlmunoz commented Jan 29, 2025

llvm: b270525f730be6e7196667925f5a9bfa153262e9
stablehlo: 459e481b

hamptonm1
hamptonm1 reviewed Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@hamptonm1 hamptonm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I had one comment

AlexandreEichenberger
AlexandreEichenberger reviewed Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hamptonm1 thanks for reviewing this, I will assume that you will approve it once you are satisfied with the answers to your question.

@christopherlmunoz
upgrading llvm and stablehlo hash. Fixing mlir tests
3784890 
Signed-off-by: Christopher Munoz <[email protected]>

formatting fixes
@christopherlmunoz christopherlmunoz force-pushed the llvm_update branch 2 times, most recently from 272152d to 3784890 Compare January 30, 2025 13:02
@hamptonm1
Copy link
Collaborator

hamptonm1 commented Feb 5, 2025

@AlexandreEichenberger @tungld I think Chris mentioned he was working with you guys to resolve the round backend test but if we can not get it resolved, would it be okay to comment it out and open an issue to fix it later on?

----------------------------- Captured stderr call -----------------------------
failed to legalize operation 'vector.shape_cast'
=========================== short test summary info ============================
 Release/test.py::OnnxBackendNodeModelTest::test_round_cpu - subprocess.Calle...

@christopherlmunoz christopherlmunoz mentioned this pull request Feb 6, 2025
Closed
@christopherlmunoz
commenting out failng tests
c6307f4 
Signed-off-by: Christopher Munoz <[email protected]>
@christopherlmunoz christopherlmunoz force-pushed the llvm_update branch 2 times, most recently from 8b9e8b1 to c6307f4 Compare February 6, 2025 02:42
@christopherlmunoz
Copy link
Contributor Author

christopherlmunoz commented Feb 6, 2025

@AlexandreEichenberger @tungld I think Chris mentioned he was working with you guys to resolve the round backend test but if we can not get it resolved, would it be okay to comment it out and open an issue to fix it later on?

----------------------------- Captured stderr call -----------------------------
failed to legalize operation 'vector.shape_cast'
=========================== short test summary info ============================
 Release/test.py::OnnxBackendNodeModelTest::test_round_cpu - subprocess.Calle...

I spoke with Tung again. Created issue #3068 and commented out tests. Will continue the investigation and work to resolve this asap.

@christopherlmunoz
commenting out failng tests
649afcb 
Signed-off-by: Christopher Munoz <[email protected]>
@hamptonm1
Copy link
Collaborator

hamptonm1 commented Feb 6, 2025

@christopherlmunoz Before I approve, please reach out to @jorickert via slack to answer the question above. I want to make sure the TOSA updates are fine before merging in.

@AlexandreEichenberger
Copy link
Collaborator

AlexandreEichenberger commented Feb 6, 2025 •
edited
Loading

I spoke with Tung again. Created issue #3068 and commented out tests. Will continue the investigation and work to resolve this asap.

I can look at that issue, since it impacts quantization operations. Can we quantize benchmarks without this fix? If we cannot, then this PR should not go in.

jorickert
jorickert approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@jorickert jorickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tosa.pad will need to be changed again when the LLVM bump containing llvm/llvm-project#123133 lands

jorickert
jorickert reviewed Feb 7, 2025
View reviewed changes
@hamptonm1
Copy link
Collaborator

hamptonm1 commented Feb 10, 2025

@AlexandreEichenberger Were you able to resolve the backend test? I know you wanted to fix that before merging this PR.

@AlexandreEichenberger
Copy link
Collaborator

AlexandreEichenberger commented Feb 12, 2025

Please go ahead with this, if the path that generates the error listed in #3068 is disabled. I.e. not just the test, but the options that generates the offending code.

@tungld tungld merged commit df601dc into onnx:main Feb 14, 2025
6 checks passed
@jenkins-droid
Copy link
Collaborator

jenkins-droid commented Feb 14, 2025

Jenkins Linux amd64 Build #16305 [push] null... failed after 2 hr 10 min

@jenkins-droid
Copy link
Collaborator

jenkins-droid commented Feb 14, 2025

Jenkins Linux s390x Build #16307 [push] null... failed after 2 hr 22 min

jorickert pushed a commit to Xilinx/onnx-mlir that referenced this pull request Mar 21, 2025
@christopherlmunoz @jorickert
AMD extension: Bump to e240261
81a1ff8 
Upgrading llvm and stablehlo hash (onnx#3053)

* upgrading llvm and stablehlo hash. Fixing mlir tests

Signed-off-by: Christopher Munoz <[email protected]>

* fixing vector shapecast bug introduced by upgraded llvm

Signed-off-by: Christopher Munoz <[email protected]>

---------

Signed-off-by: Christopher Munoz <[email protected]>
jorickert pushed a commit to Xilinx/onnx-mlir that referenced this pull request Mar 21, 2025
@christopherlmunoz @jorickert
AMD extension: Bump to e240261
c012f60 
Upgrading llvm and stablehlo hash (onnx#3053)

* upgrading llvm and stablehlo hash. Fixing mlir tests

Signed-off-by: Christopher Munoz <[email protected]>

* fixing vector shapecast bug introduced by upgraded llvm

Signed-off-by: Christopher Munoz <[email protected]>

---------

Signed-off-by: Christopher Munoz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexandreEichenberger AlexandreEichenberger AlexandreEichenberger left review comments

@jorickert jorickert jorickert approved these changes

@hamptonm1 hamptonm1 hamptonm1 left review comments

@tungld tungld Awaiting requested review from tungld

Assignees

@christopherlmunoz christopherlmunoz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@christopherlmunoz @hamptonm1 @AlexandreEichenberger @jenkins-droid @jorickert @tungld