Modernize pass instrument

[juhyunbae17]

This PR is to modernize Instrument pass. Following is included

• definition of options moves to .td and options will be generated by TableGen
• change multi-positional createInstrumentPass() to single positional so that its declaration and pass registration code can be generated by TableGen instead of having explicit declaration of it alongside TableGen already used in this Instrument Pass.

[jenkins-droid]

Can one of the admins verify this patch?

[chentong319]

Yes, this PR is the right direction.
One thing I am not sure whether we should use InstrumentPassOption directly, or create a new createInstrumentPass function to hide the details of construction of InstrumentPassOption. In MLIR, both approaches are used in different dialect. What's your opinion?

[juhyunbae17]

If the concern is about too many pass options exposed (perhaps unnecessarily) to user and help messages, it seems there is a way we could hide certain options with following flag in the .td file

In .td file,

def MyPass : Pass<"my-pass"> {
  let summary = "Example pass with a hidden option";
  let options = [
    Option<"myOption", "my-option", "bool", /*default=*/"false",
           "A description of the option",
           "llvm::cl::Hidden"> // <--- This hides it from standard --help
  ];
}

I don't know if others have second opinion.

[tungld]

LGTM. Thank you for the update!

[tungld]

@jenkins-droid test this please