Open
Conversation
Signed-off-by: Tung D. Le <tung@jp.ibm.com>
Signed-off-by: Tung D. Le <tung@jp.ibm.com>
Signed-off-by: Tung D. Le <tung@jp.ibm.com>
juhyunbae17
reviewed
Feb 27, 2026
| }; | ||
| } // namespace onnx_mlir | ||
|
|
||
| /*! |
Collaborator
There was a problem hiding this comment.
The same change is under review at https://github.com/onnx/onnx-mlir/pull/3395/changes#diff-dfa6b1d61557fd234264978117f409dc6b74961f24d21248ae8dd2e5d1f63970L125-L136
juhyunbae17
reviewed
Feb 27, 2026
| }); | ||
| } | ||
| }; | ||
| } // namespace onnx_mlir |
Collaborator
There was a problem hiding this comment.
The same change is under review at https://github.com/onnx/onnx-mlir/pull/3395/changes#diff-2298224dffdb2afffc9ea21a0ac6f06353997a1f8c1277ac81ae48db63523d97L183
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are many warnings when running
cmake --build . --target onnx-mlir, many of them are related to ElementsAttrBuilder.cpp and tablegen-based pass definitions.This PR fixed all warnings in the build.