check model's input and output naming convention (#127)

* check model's input and output naming convention

* use isdigit() instead of isnumeric()

* merge the loops and handle the all underscore name cases

* print out names that are not compliant

* minor code tuning

* use tensorflow v1.9.0 because tensorflow v1.10.0 requires protobuf v3.6.0, which windows platform doesn't support yet

Author: stevenlix

onnxmltools/convert/common/_topology.py

@@ -5,6 +5,7 @@
 # --------------------------------------------------------------------------
 
 import re
+import warnings
 from distutils.version import StrictVersion
 from ...proto import onnx
 from ...proto import helper
@@ -649,17 +650,31 @@ def convert_topology(topology, model_name, doc_string, targeted_onnx):
                     other_outputs[variable.raw_name] = variable
 
     # Add roots the graph according to their order in the original model
+    invalid_name = []
     for name in topology.raw_model.input_names:
+        # Check input naming convention
+        input_name = name.replace('_', '')
+        if input_name and (input_name[0].isdigit() or (not input_name.isalnum())):
+            invalid_name.append(name)
         if name in tensor_inputs:
             container.add_input(tensor_inputs[name])
+    if invalid_name:
+        warnings.warn('Some input names are not compliant with ONNX naming convention: %s' % invalid_name)
     for name in topology.raw_model.input_names:
         if name in other_inputs:
             container.add_input(other_inputs[name])
 
     # Add leaves the graph according to their order in the original model
+    invalid_name = []
     for name in topology.raw_model.output_names:
+        # Check output naming convention
+        output_name = name.replace('_', '')
+        if output_name and (output_name[0].isdigit() or (not output_name.isalnum())):
+            invalid_name.append(name)
         if name in tensor_outputs:
             container.add_output(tensor_outputs[name])
+    if invalid_name:
+        warnings.warn('Some output names are not compliant with ONNX naming convention: %s' % invalid_name)
     for name in topology.raw_model.output_names:
         if name in other_outputs:
             container.add_output(other_outputs[name])

requirements-dev.txt

@@ -1,7 +1,7 @@
 numpy
 protobuf
 codecov
-tensorflow
+tensorflow==1.9.0
 keras==2.1.6
 coremltools
 pandas