Replace standard GHA workflows with reusables#230
Open
eb-oss wants to merge 3 commits intoonosproject:masterfrom
Open
Replace standard GHA workflows with reusables#230eb-oss wants to merge 3 commits intoonosproject:masterfrom
eb-oss wants to merge 3 commits intoonosproject:masterfrom
Conversation
Signed-off-by: Eric Ball <eball@linuxfoundation.org>
Signed-off-by: Andy Bavier <andybavier@gmail.com>
Contributor
|
It looks to me like the build-and-test job runs golangci-lint v1.15.2 and the lint job run golangci-lint v2.8.0. They are both reading the .golangci.yml file but one expects v1 format and the other v2. |
Yes, we migrated the .golangci.yml file to v2 in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Ball eball@linuxfoundation.org