Add kid header requirement for private_key_jwt#714
Add kid header requirement for private_key_jwt#714melanconj wants to merge 2 commits intodevelopmentfrom
Conversation
kieran242
left a comment
There was a problem hiding this comment.
@jmelancondev Approved
HansBusch
left a comment
There was a problem hiding this comment.
Two editioal remarks:
- Just by putting it in the same paragraph as the previous sentence doesn't inherit the condition.
- The term assertion is quite vague. Do you mean the client_assertion field?
Does ONVIF really need to defer from OpendID Connect as the
OpenID Connect Core Specification states in chapter 9 Client Authentication:
Clients that have registered a public key sign a JWT using that key. The chapter is very specifically talking about a single key.
If ONVIF wants to extend that design it should give some rationale why and when a kid is needed.
|
Did some more research and got to the conclusion that putting the kid in the assertion header is nicely documented in Section 4.1.4 of RFC 7515. Suggest to add RFC 7515 as reference and refer to that section in case the key of an authorization server configuration is updated. Suggest to add a paragraph to 5.6.3 SetAuthorizationServerConfiguration: When the KeyID of a configuration is changed the device should include the |
|
Clarification seems fine to me, always feels a bit weird that the Set*Configuration gives requirements about how to do something that's not related to the call itself, but it's still better than the previous location. Only thing is that I kept the shall, otherwise we're not properly addressing the concerns raised in onvif/wg_profile_cloud#142 and we might as well not make any changes |
|
@sujithhanwha label needs to change to 26.12 |
As discussed in Profile V working group, OpenId Connect specification requires the presence of the
kidheader field inprivate_key_jwtassertions to allow for the Identity Provider to determine which key it shall use for the given clientid to validate the assertion against.I'm adding a requirement when using private_key_jwt to add the configured KeyID to the kid header. This value is already known by the client and can be configured (out of band) on the identity server so it can match it.
Closes onvif/wg_profile_cloud#142