Calling an not implemented optional fault should be a sender error.#715
Calling an not implemented optional fault should be a sender error.#715HansBusch wants to merge 2 commits intodevelopmentfrom
Conversation
doc/Core.xml
Outdated
| <row> | ||
| <entry> | ||
| <para>env:Receiver</para> | ||
| <para>env:Sender</para> |
There was a problem hiding this comment.
Not sure I agree, the sender has sent a potentially valid command, it is the receiver that isn't implementing it/supporting it. It felt correct before
There was a problem hiding this comment.
I see two potential cases:
- the device signals the availability of a method via its capability but doesn't implement. This is clearly a device aka receiver issue.
- the device doesn't signal the availability of a method via its capability and the client nevertheless calls it. This is clearly a client aka sender issue.
A well implemented device should respond as 2. and a badly implemented one as 1.
As the device is the one that decides I prefer option 2. If it missbehaves it is a bug.
|
As we are trying to update core spec, we need to validate the impact on the DTT and or relevant tests that can get affected by this. |
doc/Core.xml
Outdated
| <row> | ||
| <entry> | ||
| <para>env:Receiver</para> | ||
| <para>env:Sender</para> |
There was a problem hiding this comment.
This fault is widely used at DTT which have impact on both feature discovery procedure and test cases (to check feature support for older endpoints without capabilities).
Just replacing fault at DTT will have impact for already existing implementations.
As a solution DTT could be change to expect any of env:Receiver/env:Sender, but at will not be a simple update (because of different places involved) .
Also please take in account that the same changes to be done for the real Clients.
There was a problem hiding this comment.
Then suggest to keep as is and add annotation to table 4 that the fault may be caused by sender although labeled as env:receiver.
|
@bsriramprasad , didn't notice maria's feedback. I am ok with Hans suggestion of adding a note and keep the error as is. |
No description provided.