Skip to content

Calling an not implemented optional fault should be a sender error.#715

Open
HansBusch wants to merge 2 commits intodevelopmentfrom
bugfxi/optional-action-fault
Open

Calling an not implemented optional fault should be a sender error.#715
HansBusch wants to merge 2 commits intodevelopmentfrom
bugfxi/optional-action-fault

Conversation

@HansBusch
Copy link
Copy Markdown
Member

No description provided.

doc/Core.xml Outdated
<row>
<entry>
<para>env:Receiver</para>
<para>env:Sender</para>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I agree, the sender has sent a potentially valid command, it is the receiver that isn't implementing it/supporting it. It felt correct before

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see two potential cases:

  1. the device signals the availability of a method via its capability but doesn't implement. This is clearly a device aka receiver issue.
  2. the device doesn't signal the availability of a method via its capability and the client nevertheless calls it. This is clearly a client aka sender issue.

A well implemented device should respond as 2. and a badly implemented one as 1.

As the device is the one that decides I prefer option 2. If it missbehaves it is a bug.

@bsriramprasad
Copy link
Copy Markdown
Contributor

As we are trying to update core spec, we need to validate the impact on the DTT and or relevant tests that can get affected by this.

doc/Core.xml Outdated
<row>
<entry>
<para>env:Receiver</para>
<para>env:Sender</para>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fault is widely used at DTT which have impact on both feature discovery procedure and test cases (to check feature support for older endpoints without capabilities).

Just replacing fault at DTT will have impact for already existing implementations.

As a solution DTT could be change to expect any of env:Receiver/env:Sender, but at will not be a simple update (because of different places involved) .

Also please take in account that the same changes to be done for the real Clients.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then suggest to keep as is and add annotation to table 4 that the fault may be caused by sender although labeled as env:receiver.

@bsriramprasad
Copy link
Copy Markdown
Contributor

@sujithhanwha

  • if you approve this, it will be set for merge, while the above discussion points to adding a clarification than doing requirement change, Or did I miss something?

@sujithhanwha
Copy link
Copy Markdown
Contributor

@sujithhanwha

  • if you approve this, it will be set for merge, while the above discussion points to adding a clarification than doing requirement change, Or did I miss something?

@bsriramprasad , didn't notice maria's feedback. I am ok with Hans suggestion of adding a note and keep the error as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants