Extend preset tours to recorded tours.#735
Open
HansBusch wants to merge 5 commits intodevelopmentfrom
Open
Conversation
doc/PTZ.xml
Outdated
| @@ -1734,7 +1727,8 @@ Add GeoMove</revremark> | |||
| </section> | |||
| <section> | |||
| <title>Preset Tour Operations</title> | |||
Contributor
There was a problem hiding this comment.
Should this section now be named Tour Operations?
- Rename new ExtendedPTZPresetOperations to PTZTourOperations. - Make operation extensible.
doc/PTZ.xml
Outdated
| @@ -1941,7 +1946,10 @@ Add GeoMove</revremark> | |||
| <para>Stop: indicates stopping the preset tour.</para> | |||
There was a problem hiding this comment.
Suggested change
| <para>Stop: indicates stopping the preset tour.</para> | |
| <para>Stop: indicates stopping the preset tour or the recording.</para> |
There was a problem hiding this comment.
Because the device can have a limitation on the number of recorded tours, we should have a capability. This allows a better user experience for the client by preventing the action instead of handling an error when we start the recording.
There was a problem hiding this comment.
Add a fault if maximum number of recordings is reached.
- Add separate PTZ node information about supported number of recorded tours. - Streamline requirements.
…ypes. Revert extension of tour-operations as now original set is sufficient.
| @@ -1806,14 +1814,16 @@ Add GeoMove</revremark> | |||
| <varlistentry> | |||
| <term>access class</term> | |||
| <listitem> | |||
| <para role="access">READ_MEDIA</para> | |||
| <para role="access">READ_MEDIA </para> | |||
There was a problem hiding this comment.
revert space
Suggested change
| <para role="access">READ_MEDIA </para> | |
| <para role="access">READ_MEDIA</para> |
| @@ -1806,14 +1814,16 @@ Add GeoMove</revremark> | |||
| <varlistentry> | |||
| <term>access class</term> | |||
| <listitem> | |||
| <para role="access">READ_MEDIA</para> | |||
| <para role="access">READ_MEDIA </para> | |||
| </listitem> | |||
| </varlistentry> | |||
| </variablelist> | |||
| </section> | |||
| <section> | |||
| <title>GetPresetTourOptions</title> | |||
There was a problem hiding this comment.
Add GetRecordedTourOptions for AutoStart and recurring time ?
| </listitem> | ||
| <listitem> | ||
| <para>Pause:iIndicates pausing the preset tour.</para> | ||
| <para>Record: start an new recording and override any existing recording.</para> |
There was a problem hiding this comment.
Record operation is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative proposal to supporting recording tours.