Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR performs a comprehensive cache rework, migrating from Hive to dart_mappable for serialization across all packages, replacing Hive CE with Sembast for database operations, and eliminating the copy_with_extension in favor of dart_mappable's built-in functionality.
Key changes:
- Migration from Hive CE to Sembast for local database storage
- Replacement of copy_with_extension and equatable with dart_mappable annotations
- Update of build configurations to use dart_mappable_builder instead of hive_ce_generator
Reviewed Changes
Copilot reviewed 106 out of 208 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/lyon1tomussclient/lib/src/model/* | Convert model classes to use @MappableClass and dart_mappable serialization |
| packages/lyon1mailclient/lib/src/sembast_helper.dart | Add new Sembast-based cache helper for mail actions |
| packages/lyon1examenclient/lib/src/examen_list_model.dart | Add @MappableClass annotation to model |
| packages/lyon1casclient/lib/src/credential.dart | Convert to dart_mappable from copy_with_extension |
| apps/onyx/lib/screens/settings/domain/logic/settings_logic.dart | Replace Hive operations with Sembast |
| build.yaml files | Update build configuration for dart_mappable_builder |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- Annotate enums with @MappableEnum() in core and client packages - Generate and include enum mappers for all relevant enums - Update cache service to use dart_mappable for encoding/decoding - Initialize all mappers in sembast_init - Update logic to use new mappable serialization - Switch dart_mappable and builder to local path dependencies - Fix enum serialization in izlyclient, lyon1mailclient, lyon1tomussclient, polytechcolloscopeclient - Regenerate all affected *.mapper.dart files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.