Skip to content

fix: not export filter#10

Merged
BlackHole1 merged 1 commit intomainfrom
fix-filter
Nov 26, 2025
Merged

fix: not export filter#10
BlackHole1 merged 1 commit intomainfrom
fix-filter

Conversation

@BlackHole1
Copy link
Member

No description provided.

Signed-off-by: Kevin Cui <bh@bugs.cc>
Copilot AI review requested due to automatic review settings November 26, 2025 03:04
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 26, 2025

Summary by CodeRabbit

  • New Features
    • Expanded the public API with additional filtering and pagination capabilities, enabling more flexible query construction and data filtering options.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

The change adds 11 new public exports to src/index.ts from the ./builder/filter module. These exports include builder functions (buildColumnPaginationFilter, buildCompositeColumnValueFilter, buildFilter, buildSingleColumnValueFilter), Proto type definitions (ProtoColumnPaginationFilter, ProtoCompositeColumnValueFilter, ProtoFilter, ProtoSingleColumnValueFilter), and condition types (columnPaginationFilter, compositeCondition, singleColumnCondition). This expansion broadens the library's public API surface to include filtering-related utilities alongside the existing Client export.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify that all 11 exported entities exist and are properly defined in ./builder/filter
  • Check for any naming conflicts with existing exports in the codebase
  • Confirm that exposing these builder functions and Proto types as public API is intentional and aligns with library design goals

Pre-merge checks

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Please provide a description explaining the purpose and context of exporting these filter entities.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: not export filter' follows the required format and is directly related to the changeset, which involves exporting filter-related entities.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ce6b0af and 1b882e2.

📒 Files selected for processing (1)
  • src/index.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Upload results
🔇 Additional comments (1)
src/index.ts (1)

1-13: New filter-related exports look consistent and non-breaking

Re-exporting the filter builders and Proto filter types from "./builder/filter" matches the existing export style in this index and simply broadens the public API without altering existing contracts. No issues from this file’s perspective.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a missing export issue by adding filter-related exports to the main index.ts entry point. Previously, filter functionality was not accessible to consumers of the package despite being implemented in the codebase.

Key Changes:

  • Exports 12 filter-related functions, types, and Proto objects from ./builder/filter module

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@BlackHole1 BlackHole1 merged commit d8acab1 into main Nov 26, 2025
8 checks passed
@BlackHole1 BlackHole1 deleted the fix-filter branch November 26, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants