Skip to content

fix(npm): use pnpm publish#109

Merged
crimx merged 1 commit intomainfrom
crimx-patch-1
Dec 12, 2025
Merged

fix(npm): use pnpm publish#109
crimx merged 1 commit intomainfrom
crimx-patch-1

Conversation

@crimx
Copy link
Contributor

@crimx crimx commented Dec 12, 2025

No description provided.

@crimx crimx requested a review from BlackHole1 as a code owner December 12, 2025 12:30
@coderabbitai
Copy link

coderabbitai bot commented Dec 12, 2025

Summary by CodeRabbit

  • Chores
    • Updated the release publishing workflow for improved package distribution consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

The Release job in the GitHub Actions workflow is updated to use pnpm instead of npm for publishing packages. The publish command changes from npm publish --access public to pnpm publish --access public. This modification affects only the publishing step and does not alter any prior build, install, or release logic.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

This is a straightforward, single-line configuration change that simply swaps one package manager for another in the release workflow. No complex logic, no API changes, and minimal scope.

Pre-merge checks

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess whether the description relates to the changeset. Add a description explaining the rationale for switching from npm to pnpm for publishing and any relevant context or testing performed.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format '(): ' and accurately describes the main change of replacing npm publish with pnpm publish in the release workflow.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e867e98 and c9ab93f.

📒 Files selected for processing (1)
  • .github/workflows/release.yaml (1 hunks)
🔇 Additional comments (1)
.github/workflows/release.yaml (1)

55-57: pnpm publish may fail in CI without explicit auth / workspace flags / git-check config.
Today the workflow doesn’t pass NODE_AUTH_TOKEN, and pnpm publish behavior differs from npm publish (git checks + workspace semantics). Please verify the Release job has the right token wiring and publish mode (single package vs workspace), and add the needed flags/env if required.

       - name: Publish
+        env:
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
         run: |
-          pnpm publish --access public
+          pnpm publish --access public

If this is a workspace/monorepo publish, also verify whether you need pnpm -r publish (or filters), and if CI needs --no-git-checks.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@crimx crimx requested a review from hyrious December 12, 2025 12:32
@crimx crimx merged commit 8fc3d60 into main Dec 12, 2025
1 of 2 checks passed
@crimx crimx deleted the crimx-patch-1 branch December 12, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants