feat(install): support abort installing#61
Merged
BlackHole1 merged 2 commits intooomol-lab:mainfrom Apr 1, 2025
Merged
Conversation
Signed-off-by: Kevin Cui <bh@bugs.cc>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for aborting installation processes via an AbortSignal across various install functions. Key changes include:
- Adding an optional cancelSignal property to installation options’ interfaces.
- Propagating cancelSignal through install functions and child process invocations.
- Adding tests to verify that cancellation aborts install operations correctly.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/cmd/install.ts | Introduces the cancelSignal option and propagates it to relevant functions; adds a forceKillAfterDelay parameter. |
| src/cmd/install.test.ts | Adds tests for the cancellation behavior during install-all and install-deps operations. |
Comments suppressed due to low confidence (1)
src/cmd/install.ts:254
- [nitpick] Consider extracting the '1000' magic number into a well-named constant for improved clarity and maintainability.
forceKillAfterDelay: 1000,
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
BlackHole1
force-pushed
the
support-abort-install
branch
from
d7030dc to
50eff0f
Compare
l1shen
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.