feat(info): add hostEndpoint in darwin#187
Merged
ihexon merged 1 commit intooomol-lab:mainfrom Apr 21, 2025
Merged
Conversation
Signed-off-by: Kevin Cui <bh@bugs.cc>
There was a problem hiding this comment.
Pull Request Overview
This PR updates Darwin-related information by adding the hostEndpoint field and updating the underlying API response mapping.
- Updated the OVMDarwinInfo interface in src/type.ts to include hostEndpoint and changed property delimiters to semicolons.
- Modified the RequestDarwin.info method in src/request.ts to directly cast the parsed JSON response, removing the previous transformation logic for SSH and proxy details.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/type.ts | Added hostEndpoint to the OVMDarwinInfo interface and updated delimiters. |
| src/request.ts | Removed nested transformation logic in the info() method to align with the updated API response. |
Files not reviewed (1)
- scripts/resource.json: Language not supported
Comments suppressed due to low confidence (1)
src/request.ts:132
- The removal of the transformation logic for nested SSH and proxy properties may lead to a runtime error if the API response still follows the old nested structure. Verify that the API now returns a flat object matching the updated OVMDarwinInfo interface, including the hostEndpoint field.
return JSON.parse(await this.do("info", Method.GET)) as RequestDarwinRawInfoResp;
ihexon
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.