Skip to content

feat(info): add hostEndpoint in darwin#187

Merged
ihexon merged 1 commit intooomol-lab:mainfrom
BlackHole1:add-host-endpoint
Apr 21, 2025
Merged

feat(info): add hostEndpoint in darwin#187
ihexon merged 1 commit intooomol-lab:mainfrom
BlackHole1:add-host-endpoint

Conversation

@BlackHole1
Copy link
Member

No description provided.

Signed-off-by: Kevin Cui <bh@bugs.cc>
@BlackHole1 BlackHole1 requested review from Copilot and ihexon April 21, 2025 07:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Darwin-related information by adding the hostEndpoint field and updating the underlying API response mapping.

  • Updated the OVMDarwinInfo interface in src/type.ts to include hostEndpoint and changed property delimiters to semicolons.
  • Modified the RequestDarwin.info method in src/request.ts to directly cast the parsed JSON response, removing the previous transformation logic for SSH and proxy details.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/type.ts Added hostEndpoint to the OVMDarwinInfo interface and updated delimiters.
src/request.ts Removed nested transformation logic in the info() method to align with the updated API response.
Files not reviewed (1)
  • scripts/resource.json: Language not supported
Comments suppressed due to low confidence (1)

src/request.ts:132

  • The removal of the transformation logic for nested SSH and proxy properties may lead to a runtime error if the API response still follows the old nested structure. Verify that the API now returns a flat object matching the updated OVMDarwinInfo interface, including the hostEndpoint field.
return JSON.parse(await this.do("info", Method.GET)) as RequestDarwinRawInfoResp;

@ihexon ihexon merged commit b323251 into oomol-lab:main Apr 21, 2025
1 check passed
@BlackHole1 BlackHole1 deleted the add-host-endpoint branch April 21, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants