feat(api): add hostEndpoint in /info#103
Merged
BlackHole1 merged 1 commit intooomol-lab:mainfrom Apr 21, 2025
Merged
Conversation
Signed-off-by: Kevin Cui <bh@bugs.cc>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for returning the host endpoint on the /info API endpoint. Key changes include:
- Introducing a new function, HostEndpoint, in pkg/wsl/host.go to retrieve and cache the host endpoint.
- Refactoring configuration key lookup in pkg/wsl/config.go to return both the value and a boolean.
- Updating the /info API endpoint in pkg/ipc/restful/run.go to include the hostEndpoint data.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/wsl/host.go | Added HostEndpoint function to fetch and cache the host endpoint with a TODO note for thread safety. |
| pkg/wsl/config.go | Modified configuration lookup to return string values instead of booleans. |
| pkg/ipc/restful/run.go | Extended the response structure and API logic to include hostEndpoint. |
ihexon
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.