refactor(protocol/protocol): switch to nested structs

[einar-oplabs]

The L1BlockInfo___ structs contains overlapping fields. This branch factors out the non-deprecated fields e.g. L1BlockInfoBedrockBase and embeds this as a field in L1BlockInfoBedrock:

pub struct L1BlockInfoBedrock {
    #[serde(flatten)]
    base: L1BlockInfoBedrockBase,
    /// The fee overhead for L1 data. Deprecated in ecotone.
    pub l1_fee_overhead: U256,
    /// The fee scalar for L1 data. Deprecated in ecotone.
    pub l1_fee_scalar: U256,
}

The purpose is reuse (think OOP inheritance) instead of repetition. As a side-effect this increases encapsulation.

It establishes a partial order and a chain of fully embedded structs:

L1BlockInfoBedrockBase < L1BlockInfoEcotoneBase < L1BlockInfoIsthmus < L1BlockInfoJovian

Further

L1BlockInfoBedrockBase < L1BlockInfoBedrock

and

L1BlockInfoEcotoneBase < L1BlockInfoEcotone

This is deemed necessary to get around deprecated fields in L1BlockInfoBedrock and L1BlockInfoEcotone.

To hide the implementation details, constructors have been added and destructuring is discouraged.

There is no single way to do this in Rust, but this is one way. A similar way is used op-alloy.

[codecov]

Codecov Report

❌ Patch coverage is 97.05449% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.7%. Comparing base (6a3e71c) to head (0c3d49e).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
crates/protocol/protocol/src/info/variant.rs	91.3%	15 Missing ⚠️
crates/protocol/protocol/src/info/jovian.rs	95.1%	3 Missing ⚠️
crates/protocol/protocol/src/utils.rs	85.7%	2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6a3e71c) and HEAD (0c3d49e). Click for more details.

HEAD has 19 uploads less than BASE

Flag	BASE (6a3e71c)	HEAD (0c3d49e)
proof	7	0
e2e	11	0
unit	2	1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[emhane]

nice, i like this approach. we do this in op-alloy to for payload attributes and sidecars

[theochap]

Approving to unblock. Feel free to go ahead and merge if my comment's not relevant

[op-will]

👍

[wiz-b4c72f16a4]

Wiz Scan Summary

Scanner	Findings
Vulnerabilities	4
Sensitive Data	-
Secrets	-
IaC Misconfigurations	-
SAST Findings	-
Software Supply Chain Findings	-
Total	4

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

[github-actions]

This pull request has been automatically marked as stale because it has been inactive for 3 weeks.
It will be closed in 1 week if no further activity occurs.
If you believe this PR should remain open, please add the M-prevent-stale label or leave a comment.