chore(sdk): Simplify generics syntax by using adapters by emhane · Pull Request #549 · op-rs/op-reth

emhane · 2026-01-06T08:42:15Z

Simplifies generics in various places by instead of using fully qualified syntax to access associated type, using adapters

PrimitivesTy to access associated type NodeTypes::Primitives
TxTy to access NodePrimitives::SignedTx
ReceiptTy to access NodePrimitives::Receipt
BlockTy to access NodePrimitives::Block
HeaderTy to access NodePrimitives::Header

Copilot

Pull request overview

This PR simplifies generic syntax throughout the codebase by introducing and using the PrimitivesTy<N> type adapter instead of the fully qualified syntax <N as NodeTypes>::Primitives. The change improves code readability by reducing boilerplate in type declarations.

Key changes:

Introduces PrimitivesTy type adapter for cleaner access to NodeTypes::Primitives
Updates type bounds and associated types across node components, RPC handlers, and engine services
Replaces verbose <Node::Types as NodeTypes>::Primitives syntax with concise PrimitivesTy<Node::Types>

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`crates/optimism/node/tests/it/builder.rs`	Updates test EVM configuration to use `PrimitivesTy` adapter
`crates/optimism/node/src/node.rs`	Updates EVM config and validator builder to use `PrimitivesTy` adapter
`crates/node/builder/src/rpc.rs`	Updates RPC handle types and engine validator traits to use `PrimitivesTy` adapter
`crates/node/builder/src/node.rs`	Adds import and updates `NodeTypes` implementation with `PrimitivesTy` adapter
`crates/node/builder/src/launch/invalid_block_hook.rs`	Updates invalid block hook extension trait to use `PrimitivesTy` adapter
`crates/node/builder/src/launch/common.rs`	Updates static file provider return type to use `PrimitivesTy` adapter
`crates/node/builder/src/components/mod.rs`	Updates component trait bounds to use `PrimitivesTy` adapter
`crates/node/api/src/node.rs`	Adds import and updates component traits and context to use `PrimitivesTy` adapter
`crates/engine/service/src/service.rs`	Updates engine service type aliases to use `PrimitivesTy` adapter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/optimism/node/src/node.rs

codecov · 2026-01-07T15:18:30Z

Codecov Report

❌ Patch coverage is 84.46553% with 622 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.40%. Comparing base (6c7f8ee) to head (d4f27f5).
⚠️ Report is 279 commits behind head on unstable.

Files with missing lines	Patch %	Lines
crates/optimism/trie/src/proof.rs	32.47%	131 Missing ⚠️
crates/optimism/trie/src/in_memory.rs	75.46%	119 Missing ⚠️
crates/optimism/trie/src/provider.rs	48.41%	65 Missing ⚠️
...ates/optimism/cli/src/commands/op_proofs/unwind.rs	0.00%	43 Missing ⚠️
crates/optimism/exex/src/lib.rs	92.51%	36 Missing ⚠️
crates/optimism/trie/src/metrics.rs	87.64%	33 Missing ⚠️
crates/optimism/trie/src/db/cursor.rs	96.99%	28 Missing ⚠️
...rates/optimism/cli/src/commands/op_proofs/prune.rs	0.00%	25 Missing ⚠️
crates/optimism/trie/src/cursor.rs	62.50%	18 Missing ⚠️
crates/optimism/trie/src/prune/pruner.rs	95.94%	14 Missing ⚠️
... and 21 more

Additional details and impacted files

Files with missing lines	Coverage Δ
crates/exex/exex/src/backfill/job.rs	`0.00% <ø> (ø)`
crates/optimism/cli/src/app.rs	`56.94% <100.00%> (ø)`
crates/optimism/cli/src/commands/mod.rs	`37.50% <100.00%> (ø)`
crates/optimism/consensus/src/validation/mod.rs	`29.26% <100.00%> (-16.82%)`	⬇️
crates/optimism/rpc/src/eth/mod.rs	`62.63% <ø> (ø)`
crates/optimism/rpc/src/eth/proofs.rs	`100.00% <100.00%> (ø)`
crates/optimism/trie/src/cursor_factory.rs	`100.00% <100.00%> (ø)`
crates/optimism/trie/src/db/models/change_set.rs	`100.00% <100.00%> (ø)`
crates/optimism/trie/src/db/store.rs	`98.01% <ø> (+17.24%)`	⬆️
crates/optimism/trie/src/error.rs	`100.00% <100.00%> (+100.00%)`	⬆️
... and 37 more

... and 225 files with indirect coverage changes

Flag	Coverage Δ
e2e	`35.72% <71.77%> (-1.06%)`	⬇️
unit	`23.83% <81.43%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
reth binary	`53.58% <ø> (+0.18%)`	⬆️
op historical proof	`91.87% <94.15%> (+15.25%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

wiz-b4c72f16a4 · 2026-01-08T14:07:45Z

Wiz Scan Summary

Scanner	Findings
Vulnerabilities	2
Sensitive Data	-
Secrets	-
IaC Misconfigurations	-
SAST Findings	-
Software Management Findings	-

Total	2

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@dhyaniarun1993

…163) @dhyaniarun1993 @itschaindev @sadiq1971 @meyer9 think these are the only crates we will need to touch. can update as we go. ideally the new logic will only live inside of _crates/optimism_, but we may need to generalise some components in the other crates I listed and make them customisable up at SDK (node builder _crates/node_) level to achieve this.

Fixes label name on bug issues

Fixes #165

Closes #179 --------- Co-authored-by: Julian Meyer <julian.meyer@coinbase.com>

Fixes #177 I added a few methods that should allow atomically pruning and reorging blocks. Each function should represent a single transaction. We can store trie nodes, reorg, prune in a single transaction now. I kept the bulk insert methods available for storing the current state. --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>

Ref #176 This PR adds an in-memory storage backend and tests that work with any storage backend. We can easily add more test cases to the file to test against a future SQLite backend. --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com> Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>

Based on #183 This PR adds a backfill job that accepts a DB transaction and copies the current state to the database. The transaction ensures we see a consistent view of the database at the current block, even if the node is syncing. This requires `--db.read-transaction-timeout 0`. This currently doesn't handle interrupting the job because the state may update while syncing and may read a different version of the database upon restart. --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com> Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>

No token, so this check always fails annoyingly. Disabling the upload step if missing token.

Closes #458

Closes #600 --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com> Co-authored-by: Sadiqur Rahman <sadiqurr8@gmail.com>

Closes #588

Utility for #446

Ref #611 Reverts redundant import statement diff with stable to prepare for release

Ref #611

Closes #567 This PR improves the performance of the historical state pruning logic. By refining how state updates are handled and written during pruning, we observe a significant reduction in write latency. Performance Benchmarks: Comparison run using [load_test](https://github.com/op-rs/op-reth/blob/541e889e886f3ffbee275a15f25f738b2242266a/crates/optimism/trie/src/db/store.rs#L3462) Metric | Current (Baseline) | Optimised (This PR) | Improvement -- | -- | -- | -- Write Time | ~107ms | ~50ms | ~2.1x Faster Total Duration | ~129ms | ~81ms | ~1.6x Faster

Closes #619

Closes #244

…in v1.10.1 (#617) Ref #611 Uses `reth-trie-common` dep explicitly in `reth-optimism-trie` to make sure `serde-bincode-compat` can be enabled while using reth release v1.10.1

Ref #611 Checks out deny.toml from stable branch

emhane requested review from Copilot, geoknee, sebastianst and theochap January 6, 2026 08:42

emhane requested a review from dhyaniarun1993 as a code owner January 6, 2026 08:42

emhane added the K-debt Kind: debt label Jan 6, 2026

emhane requested review from itschaindev, meyer9 and sadiq1971 as code owners January 6, 2026 08:42

emhane added the A-sdk Area: node builder SDK label Jan 6, 2026

Copilot started reviewing on behalf of emhane January 6, 2026 08:43 View session

Copilot AI reviewed Jan 6, 2026

View reviewed changes

crates/optimism/node/src/node.rs Outdated Show resolved Hide resolved

emhane requested a review from BioMark3r as a code owner January 6, 2026 08:57

emhane changed the title ~~chore(sdk): Simplify syntax by using PrimitivesTy adapter~~ chore(sdk): Simplify generics syntax by using adapters Jan 6, 2026

emhane marked this pull request as draft January 6, 2026 09:03

emhane marked this pull request as ready for review January 8, 2026 14:16

emhane force-pushed the unstable branch from 345ea23 to 726ec5f Compare January 13, 2026 11:29

emhane requested a review from op-will as a code owner January 13, 2026 11:29

emhane force-pushed the emhane/use-primitive-types-adapters branch from c30e6f7 to a105bfe Compare January 13, 2026 13:43

emhane force-pushed the unstable branch from 92040ed to 7f6d3fa Compare January 15, 2026 13:54

emhane and others added 8 commits January 20, 2026 11:36

fix(ci): automatic bug label for bug issue (#180)

8a20452

Fixes label name on bug issues

feat: create initial external-proofs ExEx crate (#181)

a02567e

Fixes #165

chore: fix ci runners (#195)

07b4af9

Closes #179 --------- Co-authored-by: Julian Meyer <julian.meyer@coinbase.com>

chore: disable codspeed in op-reth (#220)

aea9fee

No token, so this check always fails annoyingly. Disabling the upload step if missing token.

dhyaniarun1993 and others added 8 commits January 20, 2026 11:45

fix: db_stat after upstream pull (#601)

e2828d8

fix: docs after upstream pull (#603)

4cd894d

test: unit test for exex (#599)

eb920aa

Closes #458

fix: MdbxStorageCursor non first key issue (#602)

9738470

Closes #600 --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com> Co-authored-by: Sadiqur Rahman <sadiqurr8@gmail.com>

chore: added exex missing tests (#605)

6f8e381

Closes #588

Fix conflicts

b6c289b

chore: getProof benchmark utility added (#550)

6bd901b

Utility for #446

Update lockfile

7b2a5ac

emhane force-pushed the unstable branch from 480cc99 to 7b2a5ac Compare January 20, 2026 11:32

emhane and others added 12 commits January 20, 2026 17:49

chore(evm): Revert redundant diff with stable (#608)

5abe287

Ref #611 Reverts redundant import statement diff with stable to prepare for release

chore(ci): fix compact ci workflow (#609)

157ae1a

chore(payload-builder): Rm empty file (#616)

d355377

Ref #611

fix: prune redundant tombstones at history horizon (#620)

ab68c9e

Closes #619

feat: backfill job restart-safe and idempotent (#594)

10878ca

Closes #244

chore(trie): Use reth-trie-common to enable serde-bincode-compat …

8d817e7

…in v1.10.1 (#617) Ref #611 Uses `reth-trie-common` dep explicitly in `reth-optimism-trie` to make sure `serde-bincode-compat` can be enabled while using reth release v1.10.1

chore(deps): Use stable deny.toml (#618)

8fbd3be

Ref #611 Checks out deny.toml from stable branch

Simplify syntax with primitive type adapters

8206ec8

Simplify syntax with primitive type adapters

f5cb7b4

Fix lint

b686b96

Update lockfile

7c5ff98

emhane force-pushed the emhane/use-primitive-types-adapters branch from 58d4418 to 7c5ff98 Compare January 22, 2026 13:25

Fix lint

d4f27f5

emhane force-pushed the unstable branch from 34d43c4 to bdb7131 Compare January 26, 2026 10:54

github-actions bot added S-stale Status: stale and removed S-stale Status: stale labels Feb 17, 2026

github-actions bot added S-stale Status: stale and removed S-stale Status: stale labels Mar 12, 2026

github-actions bot added S-stale Status: stale and removed S-stale Status: stale labels Apr 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(sdk): Simplify generics syntax by using adapters#549

chore(sdk): Simplify generics syntax by using adapters#549
emhane wants to merge 206 commits intounstablefrom
emhane/use-primitive-types-adapters

emhane commented Jan 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

codecov bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

wiz-b4c72f16a4 bot commented Jan 8, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Conversation

emhane commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

codecov bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

wiz-b4c72f16a4 bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Wiz Scan Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

emhane commented Jan 6, 2026 •

edited

Loading

codecov bot commented Jan 7, 2026 •

edited

Loading

wiz-b4c72f16a4 bot commented Jan 8, 2026 •

edited

Loading