Skip to content

fix: send language updates to the opal-admin backend#1509

Merged
staceybeard merged 1 commit intomainfrom
SB.update-language-api
Feb 18, 2026
Merged

fix: send language updates to the opal-admin backend#1509
staceybeard merged 1 commit intomainfrom
SB.update-language-api

Conversation

@staceybeard
Copy link
Member

@staceybeard staceybeard commented Feb 18, 2026

By submitting this merge request, I confirm the following:

  • The merge request title follows the conventional commits convention (see Backend project's README.md)
    • feat: minor app version will be incremented.
    • fix, deps, perf: patch app version will be incremented.
    • chore, ci, etc.: app version will not be incremented.
    • See semantic-release/commit-analyzer
      for complete set of rules.

Changes

Added a call to the Opal-Admin backend API to update the user's language in the Django database.

This will fix deviation warnings in our test data that occur when a test user's language is changed in OpalDB but not in Django.

Dependencies

Issues

Closes #1484

Copy link
Member

@mschoettle mschoettle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot!

One comment: If there first update fails but the second succeeds we will have a deviation again. Although it is quite unlikely to happen :)

@mschoettle
Copy link
Member

Another comment: Are we showing the de option in the app? In that case, would that cause any issues/deviations?

@staceybeard
Copy link
Member Author

Looks good, thanks a lot!

One comment: If there first update fails but the second succeeds we will have a deviation again. Although it is quite unlikely to happen :)

Thanks!

Yes, that's a good point, but probably a rare case. We can fix it manually if it ever happens, probably not worth the effort of adding transactional handling.

Another comment: Are we showing the de option in the app? In that case, would that cause any issues/deviations?

I've fully tested it and both the listener and backend reject the change when given an unsupported language, so it won't create any new deviations. Consistent between both.

@staceybeard staceybeard merged commit 4b0560e into main Feb 18, 2026
5 checks passed
@staceybeard staceybeard deleted the SB.update-language-api branch February 18, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use new API endpoint to update language

2 participants