fix: send language updates to the opal-admin backend#1509
Conversation
mschoettle
left a comment
There was a problem hiding this comment.
Looks good, thanks a lot!
One comment: If there first update fails but the second succeeds we will have a deviation again. Although it is quite unlikely to happen :)
|
Another comment: Are we showing the de option in the app? In that case, would that cause any issues/deviations? |
Thanks! Yes, that's a good point, but probably a rare case. We can fix it manually if it ever happens, probably not worth the effort of adding transactional handling.
I've fully tested it and both the listener and backend reject the change when given an unsupported language, so it won't create any new deviations. Consistent between both. |
By submitting this merge request, I confirm the following:
Backendproject'sREADME.md)feat: minor app version will be incremented.fix,deps,perf: patch app version will be incremented.chore,ci, etc.: app version will not be incremented.for complete set of rules.
Changes
Added a call to the Opal-Admin backend API to update the user's language in the Django database.
This will fix deviation warnings in our test data that occur when a test user's language is changed in OpalDB but not in Django.
Dependencies
Issues
Closes #1484