Skip to content

chore: add local npm hook to check that lock file is up to date#1533

Merged
mschoettle merged 4 commits intomainfrom
pre-commit-npm-hook
Mar 26, 2026
Merged

chore: add local npm hook to check that lock file is up to date#1533
mschoettle merged 4 commits intomainfrom
pre-commit-npm-hook

Conversation

@mschoettle
Copy link
Copy Markdown
Member

By submitting this pull request, I confirm the following:

Changes

Avoid committing updates to package.json without updating package-lock.json.

Dependencies

  • Listener:

Screenshots

Issues

@mschoettle mschoettle requested a review from staceybeard March 23, 2026 20:41
@mschoettle
Copy link
Copy Markdown
Member Author

The runner still has node v20 and we need v24+. It requires setting up node in the prek workflow. Closing this for now.

@mschoettle mschoettle closed this Mar 23, 2026
@mschoettle mschoettle reopened this Mar 25, 2026
@mschoettle
Copy link
Copy Markdown
Member Author

@staceybeard I realized that we don't need this hook in CI so I disabled it.

@mschoettle mschoettle merged commit 8a8e2a2 into main Mar 26, 2026
5 checks passed
@mschoettle mschoettle deleted the pre-commit-npm-hook branch March 26, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants