Adding alphabetical file sorting #472
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added configuration parameter 'log_sorting_method' - Method for sorting logs into directories
- added dependence of sorting options on the parameter 'log_sorting_method':
- with the value ModifiedTime - ['Newest first', 'Oldest first']
- with the value Alphabetical - ['From A to Z', 'From Z to A']
- supplemented sorting of files in routes 'log-viewer.folders' and 'log-viewer.files'
- supplemented tests (Failed tests did not pass before the changes)
docker compose run --rm php composer test
Tests: 4 failed, 248 passed (815 assertions)
Duration: 2.78s
Random Order Seed: 1757604409
FAIL Tests\Unit\LogIndex\LogIndexTest
⨯ it compresses chunk if gzip is available 0.01s
⨯ it can save to the cache after building up the index
FAIL Tests\Feature\LogFoldersControllerTest
⨯ it folders are sorted alphabetically descending when configured 0.03s
⨯ it can get the log files 0.02s
|
Hey @arukompas! How are you? I'd love to hear your thoughts on this pull request. If you need any changes, let me know so I can get them in. Thanks! |
arukompas
reviewed
Oct 4, 2025
| 'folder_sorting_order' => SortingOrder::Descending, | ||
|
|
||
| // Method for sorting logs into directories. Other options: `Alphabetical`, `ModifiedTime` | ||
| 'log_sorting_method' => FolderSortingMethod::ModifiedTime, |
There was a problem hiding this comment.
I think it's an important distinction between a "log" and a "file". Logs are individual log entries within a file, and here we want to sort files, not logs.
Call it file_sorting_method
| 'path' => config('log-viewer.route_path'), | ||
| 'back_to_system_url' => config('log-viewer.back_to_system_url'), | ||
| 'back_to_system_label' => config('log-viewer.back_to_system_label'), | ||
| 'log_sort_by_time' => $log_sort_by_time, |
There was a problem hiding this comment.
same here, call it files_sort_by_time instead of logs, as we're sorting files, not log entries.
There was a problem hiding this comment.
I'll try to get it done as quickly as possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#471