Fix LogFileCollection sorting to use idiomatic Laravel .all() method #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace .toArray() with .all() in sortByEarliestFirst() and sortByLatestFirst() to preserve Collection type consistency and maintain idiomatic Laravel patterns.
arukompas
force-pushed
the
fix/logfilecollection-sorting-mutation
branch
from
81dc88e to
415e15a
Compare
Update LogFileCollection and LogFolderCollection to use .all() instead of .toArray() in all sorting methods for idiomatic Laravel patterns and Collection type consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.toArray()with.all()insortByEarliestFirst()andsortByLatestFirst()methods.all()is the preferred method for direct item access, avoiding unnecessary serialization overheadTest Plan
✅ All 240 tests pass with the changes
Details
The original code used
.toArray()which performs additional formatting and serialization. Using.all()is more idiomatic and aligns with how Laravel internally mutates Collections.