Add tests for stack trace filtering in context #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

arukompas merged 8 commits into main from test/context-stack-trace-filtering

Oct 18, 2025

Contributor

arukompas commented Oct 18, 2025

Summary

Adds comprehensive tests for the context stack trace filtering feature introduced in Provide stack trace filtering in context #373
Verifies that stack traces in JSON context are filtered when the "shorter stack traces" option is enabled
Ensures vendor paths are replaced with ellipsis ( ...) while application paths remain intact
Confirms filtering doesn't occur when the feature is disabled

Test Coverage

Two new tests added to LaravelLogsTest.php:

Filters stack traces when enabled - Validates proper filtering of vendor paths in context strings
Does not filter when disabled - Ensures backward compatibility when feature is off

Test Results

✅ All 300 tests pass (939 assertions)
✅ Code formatted with Laravel Pint

Related

Closes testing gap for PR Provide stack trace filtering in context #373


          Add tests for stack trace filtering in context

55ab7c5

Tests verify that context string values are filtered when
shorter stack traces feature is enabled, ensuring vendor
paths are replaced with ellipsis while app paths remain.

arukompas self-assigned this

arukompas mentioned this pull request

Provide stack trace filtering in context #373

Merged

arukompas added 7 commits

October 18, 2025 11:59


          Normalize line endings for cross-platform compatibility

84db08b

Fixes Windows test failures by converting CRLF and CR line
endings to LF before processing stack traces.


          update gitignore

b5b6e2e


          Fix JSON context extraction on Windows

e814f0b

Handle CRLF line endings when JSON contains control characters
by replacing both \r\n and \r with escaped newlines during
JSON parsing error recovery.


          Normalize line endings in test comparison

1cef6f7

Makes test platform-independent by normalizing line endings
when comparing context values on Windows vs Unix systems.


          Always normalize context line endings

0ae5692

Normalizes line endings in all context values immediately
after JSON extraction, ensuring consistent cross-platform
behavior regardless of whether filtering is enabled.


          Normalize heredoc line endings in test

Heredocs may contain platform-specific line endings on Windows.
Normalize expected value to match the normalized context output.


          remove potentially unneeded code

ddfeeb1

arukompas merged commit d244fb6 into main

26 checks passed

arukompas deleted the test/context-stack-trace-filtering branch

October 18, 2025 10:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet