improve error for type mismatch #683
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorbash
reviewed
Jan 8, 2026
|
|
||
| defstruct reason: nil, | ||
| value: nil, | ||
| enum: [], |
Contributor
There was a problem hiding this comment.
Instead of adding a new enum field which is specific to enum schemas, to the error struct, I suggest using meta like many other kinds of errors in the same module.
zorbash
reviewed
Jan 8, 2026
| defstruct reason: nil, | ||
| value: nil, | ||
| enum: [], | ||
| format: nil, |
Contributor
There was a problem hiding this comment.
Let's also update the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there.
We have a lot of polymorphic relations in our project which leads to very unreadable errors when asserting the api spec in tests.
Since we model the jsonapi standard in our schemas every resource has a "type".
I know this problem is very specific to our use case, but extending the enum error by expected and given would make our lives way better <3