fix: prefer hasOwnProperty over hasOwn

[alaycock-stripe]

We are using Valibot for a project that requires significant browser backwards compatibility but I am unable to use some schemas because of Object.hasOwn. While this is possible to polyfill, this small change would allow us to drop our polyfill, reducing our bundle size. The tradeoff is a small reduction in readability for significantly better browser compatibility.

This change is similar to an existing polyfill, except it relies on types rather than a throwing an exception.

The change should have no runtime impact, all tests continue to pass.

Summary by CodeRabbit

• Refactor
  • Improved object property validation for better compatibility and stability.

[vercel]

@alaycock-stripe is attempting to deploy a commit to the Open Circle Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

📝 Walkthrough

Walkthrough

A single utility function in _isValidObjectKey has been updated to replace Object.hasOwn() with Object.prototype.hasOwnProperty.call() for safer property checking. No functional changes or export modifications.

Changes

Cohort / File(s)	Summary
Property Check Refactoring library/src/utils/_isValidObjectKey/_isValidObjectKey.ts	Replaced Object.hasOwn(object, key) with Object.prototype.hasOwnProperty.call(object, key) for more robust object property verification.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A safer check we now employ,
No shadow tricks to break our joy,
The prototype's direct call,
Protects our keys through one and all! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically identifies the main change: replacing Object.hasOwn with Object.prototype.hasOwnProperty.call() in the codebase to improve backwards compatibility.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR updates Valibot’s object-key validation utility to avoid Object.hasOwn and instead use Object.prototype.hasOwnProperty.call, improving compatibility with older browsers and reducing the need for a polyfill.

Changes:

• Replaced Object.hasOwn(object, key) with Object.prototype.hasOwnProperty.call(object, key) in _isValidObjectKey.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[fabian-hiller]

How much of an impact it the bundle size of the polyfill? Another option for you is to copy our object schema code (Valibot is modular so you can bring your own schemas and actions) or patch this locally (your package manager probably supports patching a library).

[alaycock-stripe]

When using core-js to polyfill several bundles are getting a ~3kb bump. I haven't explored into why the impact is so significant.

I'll look into patching, but was curious if this change would be appreciated upstream. Your tsconfig targets ES2020 but hasOwn landed in ES2022.

[fabian-hiller]

I'll look into patching, but was curious if this change would be appreciated upstream. Your tsconfig targets ES2020 but hasOwn landed in ES2022.

This is a good argument. On the other side hasOwn should have around 97% coverage across browsers and no one has complained so far. I was using hasOwn instead of hasOwnProperty because the MDN docs recommended it.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/valibot@1421

commit: 3ddb1b7

[fabian-hiller]

I think I prefer to wait before making a decision.