Rate limit ConfigurationPolicy evaluations #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinKuli
force-pushed
the
22682-rate-limit
branch
from
e31892d to
695d489
Compare
JustinKuli
changed the title
Member
Author
That feel when your rate-limiting related PR gets rate limited 😬 |
JustinKuli
force-pushed
the
22682-rate-limit
branch
2 times, most recently
from
5097292 to
186a4a8
Compare
JustinKuli
force-pushed
the
22682-rate-limit
branch
from
186a4a8 to
0bdfae4
Compare
There was already an "evaluation-backoff" flag, however it was not the first thing considered in the Reconcile, and so it had limited effectiveness. The controller-runtime ratelimiters only throttle reconciles requeued due to errors: this new implementation properly prevents a constantly updating watched resource from monopolizing the config-policy-controller. This pattern could likely easily be used in other controllers. Refs: - https://issues.redhat.com/browse/ACM-22682 Signed-off-by: Justin Kulikauskas <[email protected]>
JustinKuli
force-pushed
the
22682-rate-limit
branch
from
0bdfae4 to
ce3cce5
Compare
jan-law
approved these changes
Oct 27, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan-law, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 22e4821
into
open-cluster-management-io:main
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was already an "evaluation-backoff" flag, however it was not the first thing considered in the Reconcile, and so it had limited effectiveness. The controller-runtime ratelimiters only throttle reconciles requeued due to errors: this new implementation properly prevents a constantly updating watched resource from monopolizing the config-policy-controller.
This pattern could likely easily be used in other controllers.
Refs: