Ensure new namespaces can trigger a reconcile #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaiducek
requested changes
Oct 22, 2025
Member
dhaiducek
left a comment
dhaiducek
left a comment
There was a problem hiding this comment.
LGTM! What a subtle change! The E2E tests should use the test context, though.
JustinKuli
force-pushed
the
24595-namespaceselector-evaluation
branch
2 times, most recently
from
1e1e626 to
d430876
Compare
Previously, if the controller restarted, then policies with an evaluationInterval would not always start watching the namespaces specified in their namespaceSelectors. The intention was that new or modified namespaces could trigger evaluations even outside of the specified intervals, but this was not working. Refs: - https://issues.redhat.com/browse/ACM-24595 Signed-off-by: Justin Kulikauskas <[email protected]>
JustinKuli
force-pushed
the
24595-namespaceselector-evaluation
branch
from
d430876 to
e2a759b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit c6e2628
into
open-cluster-management-io:main
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the controller restarted, then policies with an evaluationInterval would not always start watching the namespaces specified in their namespaceSelectors. The intention was that new or modified namespaces could trigger evaluations even outside of the specified intervals, but this was not working.
Refs: