feat: allow skipObject to override mapping errors
#405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaiducek
force-pushed
the
23563-skip-mapping-errs
branch
2 times, most recently
from
b55d777 to
135e202
Compare
jan-law
reviewed
Nov 5, 2025
If a CRD does not exist on a cluster, previously that would take precedence over any Go template processing. This update runs the Go template resolver in a generic way to check whether `skipObject` had been called. ref: https://issues.redhat.com/browse/ACM-23563 Assisted-by: Cursor IDE using claude-4.5-sonnet Signed-off-by: Dale Haiducek <[email protected]>
dhaiducek
force-pushed
the
23563-skip-mapping-errs
branch
from
135e202 to
cd2bbf4
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, jan-law The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 34be92a
into
open-cluster-management-io:main
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a CRD does not exist on a cluster, previously that would take precedence over any Go template processing. This update runs the Go template resolver in a generic way to check whether
skipObjecthad been called.ref: https://issues.redhat.com/browse/ACM-23563
Assisted-by: Cursor IDE using claude-4.5-sonnet