fix: Disable pruning during reconciliation when objectSelector is used #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dhaiducek
force-pushed
the
disable-pruning-with-objectselector
branch
from
812bf5a to
19117c7
Compare
Fixes issue where objects could be updated then deleted when the update causes them to stop matching the objectSelector. Objects are still cleaned up when the policy is deleted. ref: https://issues.redhat.com/browse/ACM-26186 Signed-off-by: Dale Haiducek <[email protected]>
dhaiducek
force-pushed
the
disable-pruning-with-objectselector
branch
from
19117c7 to
1babbed
Compare
Member
Author
|
/hold for reviews and to add tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where objects could be updated then deleted when the update causes them to stop matching the objectSelector. Objects are still cleaned up when the policy is deleted.
ref: https://issues.redhat.com/browse/ACM-26186
Assisted-by: Cursor IDE using claude-4.5-sonnet