Handle non-string labels and annotations #411
Merged
+127
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
An updated "mismatch" test was a good demonstration of the old behavior. Here's what the test would require with the old behavior, when the policy has invalid labels and annotations: And it's clear that if the policy was enforced, it would delete the labels and annotations. |
dhaiducek
reviewed
Nov 12, 2025
Previously, if labels or annotations inside an objectTemplate used values that were not strings, the ConfigurationPolicy might try to remove all labels or annotations on that object. That behavior was potentially destructive, and it was easy for a policy author to accidentally trigger by getting some quotes wrong in their template, or by using `yes` as a value (which is interpreted by some parsers as a boolean `true`). Now, the ConfigurationPolicy will emit a special error if the input object template has invalid labels or annotations. Refs: - https://issues.redhat.com/browse/ACM-26186 Signed-off-by: Justin Kulikauskas <[email protected]>
JustinKuli
force-pushed
the
26186-convert-invalid-metadata
branch
from
217a12b to
c806d02
Compare
JustinKuli
changed the title
dhaiducek
approved these changes
Nov 12, 2025
Member
dhaiducek
left a comment
dhaiducek
left a comment
There was a problem hiding this comment.
This looks great to me! Thanks for working it out!
|
|
||
| # Compliance messages: | ||
| NonCompliant; violation - pods [nginx-pod-e2e-10] found but not as specified in namespace managed | ||
| NonCompliant; violation - invalid annotation, error: contains non-string value in the map under key "case": 10 is of the type int64, expected string |
Member
There was a problem hiding this comment.
This error is so clearly written it makes me want to cry 🥹
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit c20f555
into
open-cluster-management-io:main
27 of 31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if labels or annotations inside an objectTemplate used values that were not strings, the ConfigurationPolicy might try to remove all labels or annotations on that object. That behavior was potentially destructive, and it was easy for a policy author to accidentally trigger by getting some quotes wrong in their template, or by using
yesas a value (which is interpreted by some parsers as a booleantrue).Now, the ConfigurationPolicy will emit a special error if the input object template has invalid labels or annotations.
Refs: