Skip to content

🌱 [DO NOT MERGE] Debugging flaky test in spokecluster_aws_joining_test in github workflow #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

🌱 [DO NOT MERGE] Debugging flaky test in spokecluster_aws_joining_test in github workflow #1192

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab99eb6
Updating pre.yml to run only registration integration test
amrcoder Sep 22, 2025
ee6cdd7
Updating make target to run only specific tests
amrcoder Sep 22, 2025
dfd939e
Updating test file to retrigger integration test: attemp 1
amrcoder Sep 22, 2025
47dac89
Updating test file to retrigger integration test: attempt 2
amrcoder Sep 22, 2025
cab5ddd
Updating test file to retrigger integration test: attempt 3
amrcoder Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions .github/workflows/pre.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,27 +50,27 @@ jobs:
- name: build
run: make build

unit:
name: unit
runs-on: ubuntu-latest
steps:
- name: checkout code
uses: actions/checkout@v5
- name: install Go
uses: actions/setup-go@v5
with:
go-version: ${{ env.GO_VERSION }}
- name: unit
run: make test
- name: report coverage
uses: codecov/codecov-action@v5
with:
token: ${{ secrets.CODECOV_UPLOAD_TOKEN }}
files: ./coverage.out
flags: unit
name: unit
verbose: true
fail_ci_if_error: false
# unit:
# name: unit
# runs-on: ubuntu-latest
# steps:
# - name: checkout code
# uses: actions/checkout@v5
# - name: install Go
# uses: actions/setup-go@v5
# with:
# go-version: ${{ env.GO_VERSION }}
# - name: unit
# run: make test
# - name: report coverage
# uses: codecov/codecov-action@v5
# with:
# token: ${{ secrets.CODECOV_UPLOAD_TOKEN }}
# files: ./coverage.out
# flags: unit
# name: unit
# verbose: true
# fail_ci_if_error: false

integration:
name: integration
Expand All @@ -83,4 +83,4 @@ jobs:
with:
go-version: ${{ env.GO_VERSION }}
- name: integration
run: make test-integration
run: ARGS="-test.v" make test-registration-integration
2 changes: 1 addition & 1 deletion test/integration-test.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ build-work-integration:

test-registration-integration: ensure-kubebuilder-tools
go test -c ./test/integration/registration -o ./registration-integration.test
./registration-integration.test -ginkgo.slow-spec-threshold=15s -ginkgo.v -ginkgo.fail-fast ${ARGS}
./registration-integration.test -ginkgo.slow-spec-threshold=15s -ginkgo.v -ginkgo.fail-fast --ginkgo.focus "Joining Process for aws flow" ${ARGS}
Copy link

@coderabbitai coderabbitai bot Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

🧩 Analysis chain

Use -ginkgo.focus with the compiled test binary (single dash).

--ginkgo.focus is for the ginkgo CLI; the compiled test binary expects -ginkgo.focus. Using the wrong form risks ignoring the filter or flag-parsing errors.

Apply this diff:

-	./registration-integration.test -ginkgo.slow-spec-threshold=15s -ginkgo.v -ginkgo.fail-fast --ginkgo.focus "Joining Process for aws flow" ${ARGS}
+	./registration-integration.test -ginkgo.slow-spec-threshold=15s -ginkgo.v -ginkgo.fail-fast -ginkgo.focus="Joining Process for aws flow" ${ARGS}

Run to confirm the focus pattern matches an actual spec title:

🏁 Script executed:

#!/bin/bash
# Verify the focused spec exists (case/spacing sensitive).
rg -nP -C2 'Joining Process.*aws flow' test/integration/registration --type go || {
  echo "No exact match found. Nearby candidates:" >&2
  rg -nP -C2 'Joining Process|aws flow' test/integration/registration --type go
}

Length of output: 565

Use -ginkgo.focus with the compiled test binary (single dash).
Spec found at test/integration/registration/spokecluster_aws_joining_test.go:28 — change the flag so the compiled test binary receives the focus.

-	./registration-integration.test -ginkgo.slow-spec-threshold=15s -ginkgo.v -ginkgo.fail-fast --ginkgo.focus "Joining Process for aws flow" ${ARGS}
+	./registration-integration.test -ginkgo.slow-spec-threshold=15s -ginkgo.v -ginkgo.fail-fast -ginkgo.focus="Joining Process for aws flow" ${ARGS}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
./registration-integration.test -ginkgo.slow-spec-threshold=15s -ginkgo.v -ginkgo.fail-fast --ginkgo.focus "Joining Process for aws flow" ${ARGS}
./registration-integration.test -ginkgo.slow-spec-threshold=15s -ginkgo.v -ginkgo.fail-fast -ginkgo.focus="Joining Process for aws flow" ${ARGS}
🤖 Prompt for AI Agents 
In test/integration-test.mk around line 34, the Makefile passes the Ginkgo focus
flag to the compiled test binary as "--ginkgo.focus" but the compiled binary
expects the single-dash form; replace "--ginkgo.focus" (or "-ginkgo.focus") with
"-focus" and keep the existing quoted pattern and other flags intact so the
command becomes the compiled test binary receiving -focus "Joining Process for
aws flow" ${ARGS}.

.PHONY: test-registration-integration

test-work-integration: ensure-kubebuilder-tools build-work-integration
Expand Down
3 changes: 2 additions & 1 deletion test/integration/registration/spokecluster_aws_joining_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@
)

// use ordered container since we need to run beforeAll to restart the hub with aws option
var _ = ginkgo.Describe("Joining Process for aws flow", ginkgo.Ordered, func() {
ginkgo.Describe("Joining Process for aws flow", ginkgo.Ordered, func() {

Check failure on line 28 in test/integration/registration/spokecluster_aws_joining_test.go

View workflow job for this annotation

GitHub Actions / verify 

expected declaration, found ginkgo

Check failure on line 28 in test/integration/registration/spokecluster_aws_joining_test.go

View workflow job for this annotation

GitHub Actions / verify 

expected declaration, found ginkgo

Check failure on line 28 in test/integration/registration/spokecluster_aws_joining_test.go

View workflow job for this annotation

GitHub Actions / integration 

expected declaration, found ginkgo
var bootstrapKubeconfig string
var managedClusterName string
var hubKubeconfigSecret string
var hubKubeconfigDir string

ginkgo.BeforeAll(func() {

Check failure on line 34 in test/integration/registration/spokecluster_aws_joining_test.go

View workflow job for this annotation

GitHub Actions / verify 

expected declaration, found ginkgo
// stop the hub and start new hub with the updated option
stopHub()

Expand Down Expand Up @@ -59,7 +59,7 @@
ginkgo.It("managedcluster should join successfully for aws flow", func() {
var err error

managedClusterArn := "arn:aws:eks:us-west-2:123456789012:cluster/managed-cluster1"

Check failure on line 62 in test/integration/registration/spokecluster_aws_joining_test.go

View workflow job for this annotation

GitHub Actions / verify 

expected declaration, found managedClusterArn
managedClusterRoleSuffix := "7f8141296c75f2871e3d030f85c35692"
hubClusterArn := "arn:aws:eks:us-west-2:123456789012:cluster/hub-cluster1"

Expand Down Expand Up @@ -257,6 +257,7 @@
cancel := runAgent("joiningtest", agentOptions, commOptions, spokeCfg)
defer cancel()

fmt.Printf("testing flaky test attempt 1\n")
// The ManagedCluster CR should be created
gomega.Eventually(func() error {
_, err := util.GetManagedCluster(clusterClient, managedClusterName)
Expand Down
Loading