Document feedbackScrapeType in ManifestWork #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation for the feedbackScrapeType field that allows users to choose between Poll and Watch modes for collecting resource feedback. - Explain Poll (default) and Watch modes - Provide configuration example with Watch mode - Document important considerations for Watch mode including resource consumption and automatic fallback behavior - Include information about --max-feedback-watch flag and informer cleanup Fixes open-cluster-management-io#538 Co-Authored-By: Claude Sonnet 4.5 <[email protected]> Signed-off-by: Jian Qiu <[email protected]>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for open-cluster-management ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
/LGTM |
openshift-merge-bot
bot
merged commit 47d8152
into
open-cluster-management-io:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds documentation for the
feedbackScrapeTypefield in ManifestWork, which allows users to choose between Poll and Watch modes for collecting resource feedback.Changes
--max-feedback-watchflag for limiting concurrent watchesRelated Links
Fixes #538
🤖 Generated with Claude Code