Skip to content

Update to Go v1.24 #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Oct 14, 2025
Merged

Update to Go v1.24 #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci-operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
build_root_image:
name: builder
namespace: stolostron
tag: go1.23-linux
tag: go1.24-linux
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module open-cluster-management.io/policy-generator-plugin

go 1.23.0
go 1.24.0

require (
github.com/google/go-cmp v0.6.0
Expand Down
11 changes: 2 additions & 9 deletions internal/utils_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1564,11 +1564,7 @@ func TestVerifyManifestPath(t *testing.T) {
}

defer func() {
err := os.Chdir(cwd)
if err != nil {
// panic since this could affect other tests that haven't yet run
panic(fmt.Sprintf("Couldn't go back to the original working directory: %v", err))
}
t.Chdir(cwd)
}()

// Set up directory structure, with 'workingdir' as target directory:
Expand Down Expand Up @@ -1606,10 +1602,7 @@ func TestVerifyManifestPath(t *testing.T) {
t.Fatalf("Failed to write %s", otherManifestPath)
}

err = os.Chdir(workingDir)
if err != nil {
t.Fatalf("Failed to change the working directory to %s: %v", workingDir, err)
}
t.Chdir(workingDir)

grandParentDir := path.Join("..", "..")
relOtherManifestPath := path.Join("..", "otherdir", "configmap.yaml")
Expand Down