Skip to content

Conversation

@qiujian16
Copy link
Member

@qiujian16 qiujian16 commented Nov 24, 2025

  • Update open-cluster-management.io/api to v1.1.1-0.20251124092621-2337d27c3b7f (latest commit)
  • Update k8s.io libraries from v0.33.2 to v0.34.1
  • Update sigs.k8s.io/controller-runtime from v0.20.2 to v0.22.3
  • Update various transitive dependencies to compatible versions

Summary

Related issue(s)

Fixes #

Summary by CodeRabbit

  • Chores

    • Updated multiple dependency versions, including CEL-Go, Kubernetes components to v0.34.1, Open Cluster Management APIs, and various supporting libraries.
  • Tests

    • Adjusted a test expectation to align with an updated error message format.

✏️ Tip: You can customize this high-level summary in your review settings.

@openshift-ci openshift-ci bot requested a review from deads2k November 24, 2025 13:54
@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Nov 24, 2025

Walkthrough

Updated many dependency versions in go.mod and a small test expectation change in pkg/cloudevents/clients/utils/utils_test.go. No functional code changes to exported APIs detected.

Changes

Cohort / File(s) Summary
Dependency version updates
go.mod
Bumped 30+ dependencies and transitive modules (e.g., github.com/google/cel-go v0.23.2→v0.26.0, Kubernetes modules v0.33.x→v0.34.1, controller-runtime, sigs.k8s.io/yaml, structured-merge-diff, go-restful, fsnotify, grpc-middleware, reflect2, kube-openapi, open-cluster-management.io/api, etc.). No module path or Go version change.
Test expectation tweak
pkg/cloudevents/clients/utils/utils_test.go
Adjusted expected error message text in TestValidateResourceMetadata: changed "metadata: Invalid value: \"null\": ..." to "metadata: Invalid value: null: ..." (minor string update only).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify Kubernetes module bumps (api, apimachinery, apiserver, client-go, component-base) are compatible with project usage.
  • Spot-check notable dependency updates (google/cel-go v0.26.0, controller-runtime, structured-merge-diff) for known breaking changes.
  • Confirm the test string change matches intended serialization/format differences.

Possibly related PRs

Suggested labels

lgtm

Suggested reviewers

  • deads2k

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: updating dependencies to latest versions, which matches the core objective of the pull request.
Description check ✅ Passed The description provides specific details about dependency updates but lacks the Summary and Related issue(s) sections required by the template, leaving it partially incomplete.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b189d65 and b83f37f.

⛔ Files ignored due to path filters (298)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/emicklei/go-restful/v3/CHANGES.md is excluded by !vendor/**
  • vendor/github.com/emicklei/go-restful/v3/README.md is excluded by !vendor/**
  • vendor/github.com/emicklei/go-restful/v3/compress.go is excluded by !vendor/**
  • vendor/github.com/emicklei/go-restful/v3/curly.go is excluded by !vendor/**
  • vendor/github.com/emicklei/go-restful/v3/entity_accessors.go is excluded by !vendor/**
  • vendor/github.com/emicklei/go-restful/v3/json.go is excluded by !vendor/**
  • vendor/github.com/emicklei/go-restful/v3/jsoniter.go is excluded by !vendor/**
  • vendor/github.com/emicklei/go-restful/v3/jsr311.go is excluded by !vendor/**
  • vendor/github.com/emicklei/go-restful/v3/route.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/.cirrus.yml is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/.gitattributes is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/.gitignore is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/CHANGELOG.md is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/CONTRIBUTING.md is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/README.md is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/backend_fen.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/backend_inotify.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/backend_kqueue.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/backend_other.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/backend_windows.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/fsnotify.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/internal/darwin.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/internal/debug_darwin.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/internal/debug_dragonfly.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/internal/debug_freebsd.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/internal/debug_kqueue.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/internal/debug_linux.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/internal/debug_netbsd.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/internal/debug_openbsd.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/internal/debug_solaris.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/internal/debug_windows.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/internal/freebsd.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/internal/internal.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/internal/unix.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/internal/unix2.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/internal/windows.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/mkdoc.zsh is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/shared.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/staticcheck.conf is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/system_bsd.go is excluded by !vendor/**
  • vendor/github.com/fsnotify/fsnotify/system_darwin.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/README.md is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/bytestring.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/cache.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/common.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/decode.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/doc.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/encode.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/encode_map.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/encode_map_go117.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/omitzero_go124.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/omitzero_pre_go124.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/simplevalue.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/stream.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/structfields.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/tag.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/cel/BUILD.bazel is excluded by !vendor/**
  • vendor/github.com/google/cel-go/cel/decls.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/cel/env.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/cel/folding.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/cel/io.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/cel/library.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/cel/macro.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/cel/options.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/cel/program.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/cel/prompt.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/cel/templates/authoring.tmpl is excluded by !vendor/**
  • vendor/github.com/google/cel-go/cel/validator.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/checker/checker.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/checker/cost.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/checker/decls/decls.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/checker/errors.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/BUILD.bazel is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/ast/ast.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/ast/navigable.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/containers/container.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/decls/BUILD.bazel is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/decls/decls.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/doc.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/env/BUILD.bazel is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/env/env.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/stdlib/BUILD.bazel is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/stdlib/standard.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/types/BUILD.bazel is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/types/bool.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/types/bytes.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/types/double.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/types/duration.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/types/format.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/types/int.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/types/list.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/types/map.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/types/null.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/types/object.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/types/optional.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/types/string.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/types/timestamp.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/types/types.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/common/types/uint.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/ext/BUILD.bazel is excluded by !vendor/**
  • vendor/github.com/google/cel-go/ext/README.md is excluded by !vendor/**
  • vendor/github.com/google/cel-go/ext/bindings.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/ext/extension_option_factory.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/ext/formatting.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/ext/formatting_v2.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/ext/lists.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/ext/math.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/ext/native.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/ext/regex.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/ext/sets.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/ext/strings.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/interpreter/activation.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/interpreter/attribute_patterns.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/interpreter/interpretable.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/interpreter/interpreter.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/interpreter/planner.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/interpreter/runtimecost.go is excluded by !vendor/**
  • vendor/github.com/google/cel-go/parser/macro.go is excluded by !vendor/**
  • vendor/github.com/google/gnostic-models/compiler/context.go is excluded by !vendor/**
  • vendor/github.com/google/gnostic-models/compiler/extensions.go is excluded by !vendor/**
  • vendor/github.com/google/gnostic-models/compiler/helpers.go is excluded by !vendor/**
  • vendor/github.com/google/gnostic-models/compiler/reader.go is excluded by !vendor/**
  • vendor/github.com/google/gnostic-models/jsonschema/models.go is excluded by !vendor/**
  • vendor/github.com/google/gnostic-models/jsonschema/reader.go is excluded by !vendor/**
  • vendor/github.com/google/gnostic-models/jsonschema/writer.go is excluded by !vendor/**
  • vendor/github.com/google/gnostic-models/openapiv2/OpenAPIv2.go is excluded by !vendor/**
  • vendor/github.com/google/gnostic-models/openapiv2/document.go is excluded by !vendor/**
  • vendor/github.com/google/gnostic-models/openapiv3/OpenAPIv3.go is excluded by !vendor/**
  • vendor/github.com/google/gnostic-models/openapiv3/document.go is excluded by !vendor/**
  • vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/client.go is excluded by !vendor/**
  • vendor/github.com/modern-go/reflect2/safe_type.go is excluded by !vendor/**
  • vendor/github.com/spf13/pflag/.editorconfig is excluded by !vendor/**
  • vendor/github.com/spf13/pflag/.golangci.yaml is excluded by !vendor/**
  • vendor/github.com/spf13/pflag/flag.go is excluded by !vendor/**
  • vendor/github.com/spf13/pflag/ip.go is excluded by !vendor/**
  • vendor/github.com/spf13/pflag/ipnet_slice.go is excluded by !vendor/**
  • vendor/github.com/spf13/pflag/string_array.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v2/.travis.yml is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v2/LICENSE is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v2/LICENSE.libyaml is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v2/NOTICE is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v2/README.md is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v2/apic.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v2/decode.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v2/emitterc.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v2/encode.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v2/parserc.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v2/readerc.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v2/resolve.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v2/scannerc.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v2/sorter.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v2/writerc.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v2/yaml.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v2/yamlh.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v2/yamlprivateh.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v3/LICENSE is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v3/NOTICE is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v3/README.md is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v3/apic.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v3/decode.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v3/emitterc.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v3/encode.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v3/parserc.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v3/readerc.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v3/resolve.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v3/scannerc.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v3/sorter.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v3/writerc.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v3/yaml.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v3/yamlh.go is excluded by !vendor/**
  • vendor/go.yaml.in/yaml/v3/yamlprivateh.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1beta1/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1beta1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1beta1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1beta2/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1beta2/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1beta2/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/batch/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/batch/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/batch/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/certificates/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1alpha1/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1alpha1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1alpha1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1alpha1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1alpha1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/core/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/extensions/v1beta1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/extensions/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/extensions/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/extensions/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/extensions/v1beta1/zz_generated.validations.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/well_known_labels.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1/devicetaint.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/resource/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha3/devicetaint.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha3/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/resource/v1alpha3/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha3/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha3/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha3/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha3/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha3/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/resource/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1beta1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1beta2/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/resource/v1beta2/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1beta2/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1beta2/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1beta2/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/storage/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/storage/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/storage/v1/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/storage/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/storage/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/storage/v1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/storage/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/storage/v1alpha1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/storage/v1alpha1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/storage/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/storage/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/storage/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/storage/v1beta1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1/conversion.go is excluded by !vendor/**
  • vendor/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1/defaults.go is excluded by !vendor/**
  • vendor/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1/conversion.go is excluded by !vendor/**
  • vendor/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1/defaults.go is excluded by !vendor/**
  • vendor/k8s.io/apiextensions-apiserver/pkg/client/applyconfiguration/apiextensions/v1/customresourcedefinition.go is excluded by !vendor/**
  • vendor/k8s.io/apiextensions-apiserver/pkg/client/applyconfiguration/apiextensions/v1beta1/customresourcedefinition.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/errors/errors.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/operation/operation.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/safe/safe.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/validate/README.md is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/validate/common.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/validate/constraints/constraints.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/validate/content/errors.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/validate/doc.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/validate/each.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/validate/enum.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/validate/equality.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/validate/immutable.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/validate/item.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/validate/limits.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/validate/required.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/validate/subfield.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/validate/testing.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/validate/union.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/validate/zeroorone.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/api/validation/objectmeta.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/apis/meta/internalversion/validation/validation.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/apis/meta/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/apis/meta/v1/validation/validation.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/labels/labels.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/labels/selector.go is excluded by !vendor/**
  • vendor/k8s.io/apimachinery/pkg/runtime/converter.go is excluded by !vendor/**
📒 Files selected for processing (2)
  • go.mod (5 hunks)
  • pkg/cloudevents/clients/utils/utils_test.go (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-07T12:29:10.858Z
Learnt from: skeeey
Repo: open-cluster-management-io/sdk-go PR: 129
File: go.mod:3-3
Timestamp: 2025-07-07T12:29:10.858Z
Learning: Starting with Go 1.18, the `go` directive in `go.mod` files supports patch versions (e.g., `go 1.23.6`). This is valid syntax and will work correctly with Go tooling.

Applied to files:

  • go.mod
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: unit
  • GitHub Check: integration
  • GitHub Check: verify
🔇 Additional comments (4)
pkg/cloudevents/clients/utils/utils_test.go (1)

338-338: LGTM! Test expectation correctly updated for new dependency version.

The error message format changed in the updated Kubernetes libraries (v0.33.2 → v0.34.1), removing quotes around null. This test expectation adjustment is correct and expected.

go.mod (3)

56-119: Indirect dependency updates look consistent.

The indirect dependency updates appear to follow naturally from the direct dependency updates, including updates to go-restful, fsnotify, gnostic-models, and structured-merge-diff. These are expected cascading updates.


14-14: Version existence and security advisories have been confirmed. Let me check for breaking changes between v0.23.2 and v0.26.0:

✓ cel-go v0.26.0 is verified as safe to upgrade.

The v0.26.0 release includes feature additions such as global constants support, regex extensions, Sqrt function, and cost tracking improvements. A minor AST variable naming change may affect tests that inspect AST contents in text form, but will not break existing CEL usage during runtime. No security advisories were found for this version.


33-42: I need to verify whether Kubernetes v0.34.1 actually exists as a released version, since the API query returned empty results. Let me search for current Kubernetes release information.

Based on the verification results, I've confirmed the following:

Kubernetes v1.34.1 was released, and controller-runtime v0.22.3 exists. Controller-runtime v0.22 is compatible with k8s.io/*, client-go v0.34, which matches the versions in your go.mod. No security vulnerabilities were found for controller-runtime v0.22.3, and the known k8s.io/apimachinery vulnerabilities are in old versions well below v0.34.1.

Kubernetes and controller-runtime versions are compatible and free of known security advisories.

All dependency updates are valid and properly aligned. The k8s.io libraries (v0.34.1), controller-runtime (v0.22.3), and sigs.k8s.io/yaml (v1.6.0) are mutually compatible and verified to be secure.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

- Update open-cluster-management.io/api to v1.1.1-0.20251124092621-2337d27c3b7f (latest commit)
- Update k8s.io libraries from v0.33.2 to v0.34.1
- Update sigs.k8s.io/controller-runtime from v0.20.2 to v0.22.3
- Update various transitive dependencies to compatible versions

Signed-off-by: Jian Qiu <[email protected]>
@qiujian16 qiujian16 force-pushed the update-dependencies-20251124 branch from b189d65 to b83f37f Compare November 25, 2025 01:23
@elgnay
Copy link

elgnay commented Nov 25, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 25, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit c7d6056 into open-cluster-management-io:main Nov 25, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants