Skip to content

[Fix]: Remove bos_token for vllm#1834

Closed
RunningLeon wants to merge 1 commit intoopen-compass:mainfrom
RunningLeon:fix-vllm
Closed

[Fix]: Remove bos_token for vllm#1834
RunningLeon wants to merge 1 commit intoopen-compass:mainfrom
RunningLeon:fix-vllm

Conversation

@RunningLeon
Copy link
Contributor

Motivation

Remove bos_token for vllm when testing chat models.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@RunningLeon RunningLeon changed the title Remove bos_token for vllm [Fix]: Remove bos_token for vllm Jan 17, 2025
@tonysy tonysy requested review from MaiziXiao and liushz January 20, 2025 06:35
@MaiziXiao
Copy link
Contributor

Fixed in #1831

@MaiziXiao MaiziXiao closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants