Sidequest: Remove technical debt #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the deploy targets do not work anymore since the directory-structure does not exist. This is because the deployment needs an additionaly OCI registry. To deploy the controller one can use the instructions in the README.md
frewilhelm
force-pushed
the
sqRemoveTechnicalDebt
branch
from
cec6092 to
95f7a8e
Compare
Skarlso
reviewed
Nov 29, 2024
|
|
||
| # cleanup | ||
| rm -fr hack/rootCA.pem | ||
| if [[ -f hack/rootCA.pem ]]; then |
Contributor
There was a problem hiding this comment.
rm -fr will exit 0 even if the thing doesn't exist. :)
Contributor
Author
There was a problem hiding this comment.
because -f (force-)pushes are not best practice in scripts. It is surely opinionated, but force-removals can be risky and are not necessary in most situations.
Contributor
Author
There was a problem hiding this comment.
Why do you need the if?
To not use -f :D
Contributor
There was a problem hiding this comment.
In this situation we also want to make sure that a rootCA with a bad chmod or a different user is also removed. Or if it was created with a super user. But meh. :) I'm not gonna die on this hill. :D
Skarlso
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To deploy the controller one can use the instructions in the README.md
make test