Skip to content

chore: correct gosec annotation and remove gosec from codeql #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morri-son merged 12 commits into from
Feb 27, 2025
Merged

chore: correct gosec annotation and remove gosec from codeql #604

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
45ab93e
correct gosec annotation and remove gosec from codeql
morri-son Feb 24, 2025
33e51b7
move template to .github repo
morri-son Feb 24, 2025
95dfabc
remove mend
morri-son Feb 24, 2025
f9e26ec
only on schedule
morri-son Feb 25, 2025
95bd0e8
bring back pr and push
morri-son Feb 25, 2025
b0c049c
correct nolint
morri-son Feb 25, 2025
bfa900a
remove params
morri-son Feb 26, 2025
eadbdd8
correct trigger
morri-son Feb 27, 2025
6b73532
adopt schedule
morri-son Feb 27, 2025
d649f06
remove upload
morri-son Feb 27, 2025
5ce1334
Update blackduck_scan.yaml
morri-son Feb 27, 2025
0b449cd
Merge branch 'main' into correct-gosec-annotation-and-remove-gosec-fr…
morri-son Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions .github/workflows/code-scan.yml
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions api/v1alpha1/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const (
// DefaultRegistryCertificateSecretName is the name of the of certificate secret for client and registry.
DefaultRegistryCertificateSecretName = "ocm-registry-tls-certs" // #nosec G101 -- not a credential
DefaultRegistryCertificateSecretName = "ocm-registry-tls-certs" // nolint:gosec // not a credential
)

// Internal ExtraIdentity keys.
Expand Down Expand Up @@ -35,5 +35,5 @@
// Ocm credential config key for secrets.
const (
// OCMCredentialConfigKey defines the secret key to look for in case a user provides an ocm credential config.
OCMCredentialConfigKey = ".ocmcredentialconfig" // #nosec G101 -- not a credential
OCMCredentialConfigKey = ".ocmcredentialconfig" // nolint:gosec // not a credential
)
2 changes: 1 addition & 1 deletion pkg/oci/repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ func (c *Client) setupCertificates(ctx context.Context) error {
}

func (c *Client) constructTLSRoundTripper() http.RoundTripper {
tlsConfig := &tls.Config{} // #nosec G402 -- must provide lower version for quay.io
tlsConfig := &tls.Config{} // nolint:gosec // must provide lower version for quay.io
caCertPool := x509.NewCertPool()
caCertPool.AppendCertsFromPEM(c.ca)

Expand Down
Loading