Add node selector in deployments #695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dee0sap
approved these changes
Jul 17, 2025
Contributor
dee0sap
left a comment
dee0sap
left a comment
There was a problem hiding this comment.
lgtm but you should open a ticket here
https://github.com/open-component-model/ocm-project
and have it and this PR reference each other.
Member
|
@Skarlso PTAL |
Skarlso
approved these changes
Jul 18, 2025
Contributor
|
@Melonbun233 hello. Please sign all commits. Thanks! And also accept the DCO please. If you click on the job you'll see what to do. |
Signed-off-by: Henry Zeng <[email protected]>
Melonbun233
force-pushed
the
add-node-selector-to-deployments
branch
from
fe1c682 to
4617dad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Add
nodeSelectorfield in controllers deployments chart.Users can modify the
nodeSelectorfield from Helm.This PR fixes this issue.