Add an option to generate tls cert during helm install #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Melonbun233
force-pushed
the
generate-tls-cert-option
branch
from
2441d2f to
84cd690
Compare
Signed-off-by: Henry Zeng <[email protected]>
Signed-off-by: Henry Zeng <[email protected]>
Melonbun233
force-pushed
the
generate-tls-cert-option
branch
from
84cd690 to
c2c9f2b
Compare
dee0sap
reviewed
Jul 21, 2025
Contributor
dee0sap
left a comment
dee0sap
left a comment
There was a problem hiding this comment.
Please see inline comment
Signed-off-by: Henry Zeng <[email protected]>
Contributor
|
Shouldn't the |
Signed-off-by: Henry Zeng <[email protected]>
Signed-off-by: Henry Zeng <[email protected]>
Signed-off-by: Henry Zeng <[email protected]>
Skarlso
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
For clusters with cert-manager installed, we should have an option to deploy the certificate during Helm Install time.
The option should be disabled by default to not alter existing installations.
This PR also makes some controller and registry values configurable from values.yaml file
Which issue(s) this PR fixes
Fixed issue 559